Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opacity_state_to_numba should be a method of the OpacityState #2882

Open
andrewfullard opened this issue Nov 12, 2024 · 2 comments · May be fixed by #2932
Open

opacity_state_to_numba should be a method of the OpacityState #2882

andrewfullard opened this issue Nov 12, 2024 · 2 comments · May be fixed by #2932
Labels
opacity Related to opacity extensions in TARDIS restructure

Comments

@andrewfullard
Copy link
Contributor

Called e.g. to_numba.
@andrewfullard andrewfullard added restructure opacity Related to opacity extensions in TARDIS labels Nov 12, 2024
@AkashKumar7902
Copy link

Called e.g. to_numba

What do you mean by this? Could you please elaborate?

@andrewfullard
Copy link
Contributor Author

This issue is written as a reminder for senior developers. As the title says, the function opacity_state_to_numba should be a method of the OpacityState class, and it should be named to_numba, for example.

@Sonu0305 Sonu0305 linked a pull request Jan 9, 2025 that will close this issue
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
opacity Related to opacity extensions in TARDIS restructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

opacity_state_to_numba -> to_numba and moved to as a method of class OpacityState Sonu0305/tardis
2 participants
@andrewfullard @AkashKumar7902