From 9a2a2d42b635a1e27bd6a8f67f7f7b1c59acc7db Mon Sep 17 00:00:00 2001
From: Amr Bashir <amr.bashir2015@gmail.com>
Date: Fri, 8 Nov 2024 19:56:39 +0200
Subject: [PATCH] fix: call `ctx.drop_finish` in webkit2gtk drop handler
 (#1412)

---
 .changes/gnome-dragged-icon-stuck.md | 5 +++++
 src/webkitgtk/drag_drop.rs           | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)
 create mode 100644 .changes/gnome-dragged-icon-stuck.md

diff --git a/.changes/gnome-dragged-icon-stuck.md b/.changes/gnome-dragged-icon-stuck.md
new file mode 100644
index 000000000..3cead1ffa
--- /dev/null
+++ b/.changes/gnome-dragged-icon-stuck.md
@@ -0,0 +1,5 @@
+---
+"wry": "patch"
+---
+
+Fix icons of dragged items getting stuck when using `WebViewBuilder::with_drag_drop_handler` on some distros like Gnome.
diff --git a/src/webkitgtk/drag_drop.rs b/src/webkitgtk/drag_drop.rs
index 0aeafcb00..4f81dae70 100644
--- a/src/webkitgtk/drag_drop.rs
+++ b/src/webkitgtk/drag_drop.rs
@@ -92,9 +92,10 @@ pub(crate) fn connect_drag_event(webview: &WebView, handler: Box<dyn Fn(DragDrop
 
   {
     let controller = controller.clone();
-    webview.connect_drag_drop(move |_, _, x, y, _| {
+    webview.connect_drag_drop(move |_, ctx, x, y, time| {
       if controller.has_entered() {
         if let Some(paths) = controller.take_paths() {
+          ctx.drop_finish(true, time);
           controller.leave();
           return controller.call(DragDropEvent::Drop {
             paths,