Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialization of TrajOptOSQPSolverProfile fails #575

Open
rjoomen opened this issue Jan 7, 2025 · 1 comment
Open

Deserialization of TrajOptOSQPSolverProfile fails #575

rjoomen opened this issue Jan 7, 2025 · 1 comment

Comments

@rjoomen
Copy link
Contributor

rjoomen commented Jan 7, 2025

Version

latest

OS Version

Ubuntu 24.04

Describe the bug

The default value of min_approx_improve_frac is -inf. Boost can serialize this to -inf, but cannot deserialize it, see here.

This leads to a deserialization error here.

To Reproduce

auto ser_profile = std::make_shared<TrajOptOSQPSolverProfile>();
tesseract_common::Serialization::toArchiveFileXML<TrajOptOSQPSolverProfile>(*ser_profile, profile_path);

auto deser_profile = std::make_shared<T>(tesseract_common::Serialization::fromArchiveFileXML<TrajOptOSQPSolverProfile>(profile_path));

Expected behavior

Support for +/-inf. Or set the default of min_approx_improve_frac to std::numeric_limits<double>::lowest(), and of max_time to std::numeric_limits<double>::max().

Relevant log output

No response

@Levi-Armstrong
Copy link
Contributor

Levi-Armstrong commented Jan 7, 2025

I would just update to leverage numeric_limits as you suggested to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants