Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let dropdowns expand beyond Modal body in EditEvents #10544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gregorbg
Copy link
Member

@gregorbg gregorbg commented Jan 6, 2025

Really quick fix for #10522, although I'm not sure whether this breaks anything else. I did a few basic sanity checks, but I'm sure experienced Delegates have other use-cases for this panel...

Git Blame shows that we introduced the scrolling property only in #8765, which was targeted towards a specific issue with scrolling in a long list of cumulative rounds. I have changed the code so that each nested modal can decide by itself whether it wants to be scrolling or not, although the new default value is false (as opposed to before. when every modal was scrolling by default, which caused the issue with dropdowns)

@gregorbg gregorbg force-pushed the fixup/modal-scrolling branch from f3a707c to ddc9fe4 Compare January 6, 2025 07:57
@kr-matthews
Copy link
Contributor

This is also an issue with editing advancement conditions, so the same changes should be applied there. But even if I add contentScrolling there, it still looks like this:

image

image

@gregorbg
Copy link
Member Author

The point is that enabling contentScrolling is what causes the dropdown glitch. In a sense, enabling the scrollbar is precisely what "swallows" the dropdown.

The solution is to make sure that it is disabled for popups where you don't want this problem to happen. That's why the default value is set to false, and you should only enable it at all on dropdowns that have a lot of content (like the radio buttons in the cumulative cutoff window).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants