Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console shows inactive exchanges #31

Open
walne opened this issue Jun 30, 2014 · 3 comments
Open

Console shows inactive exchanges #31

walne opened this issue Jun 30, 2014 · 3 comments

Comments

@walne
Copy link
Contributor

walne commented Jun 30, 2014

After adding Coinbase & CampBXExchange as new entries to cointrader.properties, I commented them out (and had previously removed them from -default.properties. After entering "exchanges" into the console, they continue to show up as valid exchanges. (See screenshots attached)
console image
properties image

Expected Behavior: Only those active exchanges should appear as options in console.

@timolson
Copy link
Owner

Currently, the exchanges command lists all Exchanges for which there is data in the database. It does not mean that data is actively being collected. Perhaps we should add an optional live parameter, something like exchanges live? Comments?

@walne
Copy link
Contributor Author

walne commented Jul 3, 2014

That makes sense about exchanges showing which ones where data exists. I like the idea of adding the live parameter so you can see what exchanges are currently activated. Is there presently a way to confirm whether a specific (or all) exchanges are connected and either able to collect data or place a trade?

Presently, to check and see if an exchange is active/connected properly, I run watch + {listing} (that I know that is on the specific exchange's book; and then wait to see if anything comes across. Is there a more efficient way to confirm whether an exchange is active? Is it possible to watch coinbase:BTC.USD or something similar to only see book and trade data for that specific exchange?

@timolson
Copy link
Owner

timolson commented Jul 3, 2014

exchanges live would have to query the DataService to ask what is
active. We need to add the appropriate method to the DataService
interface and implement it in XchangeDataService. Then the
ExchangesCommand can bind using @Inject private DataService dataService; and invoke the necessary query method during run().

Currently watch only takes a Listing not a Market. Would you open a new
issue for that, then I'll describe there what's needed?
On Jul 3, 2014 3:13 AM, "Austin Walne" [email protected] wrote:

That makes sense about exchanges showing which ones where data exists. I
like the idea of adding the live parameter so you can see what exchanges
are currently activated. Is there presently a way to confirm whether a
specific (or all) exchanges are connected and either able to collect data
or place a trade?

Presently, to check and see if an exchange is active/connected properly,
I run watch + {listing} (that I know that is on the specific exchange's
book; and then wait to see if anything comes across. Is there a more
efficient way to confirm whether an exchange is active? Is it possible to watch
coinbase:BTC.USD or something similar to only see book and trade data for
that specific exchange?


Reply to this email directly or view it on GitHub
#31 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants