Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.3.0] Selecting image in the list still causes double loading, sometimes seg fault #73

Open
psobolewskiPhD opened this issue Jan 8, 2025 · 3 comments · May be fixed by #75
Open

[0.3.0] Selecting image in the list still causes double loading, sometimes seg fault #73

psobolewskiPhD opened this issue Jan 8, 2025 · 3 comments · May be fixed by #75
Labels
bug Something isn't working high priority Something that is important!

Comments

@psobolewskiPhD
Copy link
Collaborator

psobolewskiPhD commented Jan 8, 2025

Previously layers would be added and removed and then re-added.
Now I get duplicate layers: the image is added and a split second later added again.

Edit: This happens if I click the > to expand enclosing folders without clicking to select the folder.

I also notice these warnings in my terminal

WARNING: QObject::connect: Cannot queue arguments of type 'QItemSelection'
(Make sure 'QItemSelection' is registered using qRegisterMetaType().)
16:53:48 : WARNING : Dummy-1 : QObject::connect: Cannot queue arguments of type 'QItemSelection'
(Make sure 'QItemSelection' is registered using qRegisterMetaType().)
WARNING: QObject::connect: Cannot queue arguments of type 'QItemSelection'
(Make sure 'QItemSelection' is registered using qRegisterMetaType().)
16:53:48 : WARNING : Dummy-1 : QObject::connect: Cannot queue arguments of type 'QItemSelection'
(Make sure 'QItemSelection' is registered using qRegisterMetaType().)
@psobolewskiPhD psobolewskiPhD added bug Something isn't working high priority Something that is important! labels Jan 8, 2025
@psobolewskiPhD
Copy link
Collaborator Author

Ok, so the double loading of layers happens with the groups PR
1f60e91

The fix in #64 was to a different state of main.

@psobolewskiPhD
Copy link
Collaborator Author

Oh fun! I can reproduce both double loading and single loading.
For single loading:
Click a folder to select it, then click the > to expand, then click the image.

For double loading and the QtObject warnings:
Just click the > to expand a folder, and then click and image.
For fun, this also frequently results in seg fault, with nothing in the console!!

@psobolewskiPhD psobolewskiPhD changed the title [0.3.0] Selecting image in the list still causes double loading [0.3.0] Selecting image in the list still causes double loading, sometimes seg fault Jan 8, 2025
@jo-mueller
Copy link
Collaborator

@psobolewskiPhD thanks for the spot, I had not tested the latest release extensively. It seems to me that the root problem here is the duality of two image browsers to begin with plus the implicit image loading through selection of the item.

Removing the load event from the thumbnail grid seems a prudent course of action and I could imagine that a more explicit load functionality (doubleclick or Load button) maybe also solves our troubles with weird selection behaviors in the QTreeView 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Something that is important!
Projects
None yet
2 participants