What was the original reason on pulling in rodio?

[hasezoey]

I just noticed that playback::rusty_backend is rodio but pulled into the project.
What was the original reason it has been pulled-in and should it ever be swapped back?

[hasezoey]

something related i came across:

Previously I used rodio, but rodio doesn't support seek

#33 (comment)

so if the current state of rodio is anything to go be, it still does not support seeking RustAudio/rodio#176

[tramhao]

Yes, besides that, I also need to modify some signal for gapless playback.

[dvdsk]

As of april this year Rodio supports seeking, many other features have been added since, such as automatic gain control.

Please let us know what is missing from rodio that you need. We are currently redesigning much of the API and could use your feedback.

I hope you will be able to depend on rodio directly instead of the current vendoring situation (copying in the code) in the near future. The current vendoring situation is rather problematic from a legal point of view.

Rodio code is licensed under both the MIT and Apache License, both require attribution. That means you should mention which parts of your source code has been copied from Rodio.

[dvdsk]

Thats perfect, thank you very much for making those changes! Oh and by the way the latest rodio has automatic gain control which could be nice to have in termusic.

[hasezoey]

Oh and by the way the latest rodio has automatic gain control which could be nice to have in termusic.

Sound good, though it had not been implemented in any other backend, so it would likely take a little more effort.

I am not too much into audio and have not tried it yet, so i dont quite understand what / why it would be needed. Is this something similar to ReplayGain but for live sources and adjusted over time?
Edit: created #390

[dvdsk]

I am not too much into audio

Same tbh, I wanted to build a podcast app and I have ended up maintaining rodio and writing a streaming/download manager library 😅. Maybe I'll get on that partially finished podcast app once thats done.

Is this something similar to ReplayGain but for live sources and adjusted over time?

Yes, it allows you to limit the maximum volume and keep the average volume around a set limit. Can be useful if a song has very loud and very quite bits.

[hasezoey]

For completeness, #389, the PR to switch back to upstream rodio has been merged.