New config format question about keybinding layout

[hasezoey]

I wanted to work on a new config layout to split the server and TUI config settings (so that not too much is loaded) and refactor some property layouts, but have come across a question regarding keybinding config layout:

currently keybindings look like:

[keys.global_quit.code]
type = "Char"
args = "q"

[keys.global_quit.modifier]
type = "KeyModifiers"
bits = 0

but i wanted to make them simpler by only having one entry, but cant decide which modifier layout to go for:

choice 1: one string, delimited with + (or some other character like space )

[keys.global_quit]
key = "q"
modifiers = "SHIFT+CONTROL+ALT"

choice 2: a sequence (vec) of strings:

[keys.global_quit]
key = "q"
modifiers = ["SHIFT", "CONTROL", "ALT"]

or any other suggestions?

Note: i plan on treating any extra occurrence as one (like modifiers = "SHIFT+SHIFT+SHIFT" the same as modifiers = "SHIFT").

---

EDIT:

choice 3: combined key and modifiers:

[keys.global_quit]
key = "q+SHIFT+CONTROL+ALT"

choice 3.5: basically choice 3, but flatter:

[keys]
global_quit = "q+SHIFT+CONTROL+ALT"

Note: maybe allow both 3 and 3.5 similar to how Cargo.toml's dependencies section works?

[tramhao]

The original format is based on the serde feature of tui-realm. For new format, we'll have to parse the format by ourselves. Which is easier to parse? For me, I prefer 3.5 because the config file is more concise.

[hasezoey]

easier to parse, as in less code to write would be choice 2, but i would be confident i can write some custom de- and serialization for any of the listed choices.

we can go with choice 3.5, i personally like choice 1 / choice 2 as they are close to the original format and easy to implement, but choice 3.5 is really a lot more concise / may be easier on the user.

as for parsing, i would make it so that any double occurrence of modifiers are counted as one, but missing / having more than one other character / key would be a error.

as for serialization, what would you prefer, the key first(q+SHIFT+CONTROL+ALT) or modifiers first(SHIFT+CONTROL+ALT+q)?
also should we serialize the keys in lowercase (q+shift+control+alt) or uppercase (Q+SHIFT+CONTROL+ALT)?

any other suggestions in terms of serialization / de-serialization?

[tramhao]

Maybe all lowercase is better as uppercase is confusing combined with shift. Also mod key + letter key is more natural.