-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Org Team Approver Documentation Issue #102
Comments
I ran into the same problem and came to the same solution. |
It works for me with the additional permission up until the actual approval message, which never gets picked up. Issue is created, and even cancelled when the run is cancelled manually, but replying to the created issue with an approved response never gets picked up by the action. I've tried adding the "Issue comment" event to the permissions, which seems like an obvious necessity, but still no joy. |
Thank you for creating and sharing an amazing plugin!
The docs on the "Org Team Approver" have limited / incorrect information, the the extra "Permissions" section is misleading.
https://github.com/marketplace/actions/manual-workflow-approval#org-team-approver
I followed the docs for Team Approver setup but pipeline was failing with error below
In case of explicitly listed users the
trstringer/manual-approval@v1
step is executed withsecret: ${{ github.TOKEN }}
. However in case of Org Team Approversecret: ${{ steps.generate_token.outputs.token }}
is used. Per docs, the GitHub app was created with read-only access to organization members, which is not enough to create an issue in the repo. Once I added "Issues Write" permission to the GitHub app - the workflows worked as expected!App Permissions
The text was updated successfully, but these errors were encountered: