Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch otf2 metric mode from accumulated_start to accumulated_last #279

Open
cvonelm opened this issue Apr 28, 2023 · 1 comment
Open

Switch otf2 metric mode from accumulated_start to accumulated_last #279

cvonelm opened this issue Apr 28, 2023 · 1 comment

Comments

@cvonelm
Copy link
Member

cvonelm commented Apr 28, 2023

Currently, we are using accumulated_start for perf metrics. In this mode, the metric value we write is the sum of all metric readouts since the beginning of measurements.

Alternatively, afaik, we could use accumulated_last, where we write the individual metric readouts instead.

This is not the highest priority of issue but to my knowledge it seems that the accumulation we are doing in lo2s is unnecessary.

And additionally, with accumulation we always run the risk that issues such as #267 mess up the accumulation variable by adding values such as NaN or infinity.

@tilsche
Copy link
Member

tilsche commented Apr 29, 2023

IIRC this was done primarily because of long-standing bug(s) in Vampir. We have to carefully check if those are properly fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants