Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide virtual nav bar in full screen mode #61

Open
AeliusSaionji opened this issue May 10, 2018 · 8 comments
Open

Hide virtual nav bar in full screen mode #61

AeliusSaionji opened this issue May 10, 2018 · 8 comments

Comments

@AeliusSaionji
Copy link

No description provided.

@jafjdev
Copy link

jafjdev commented May 17, 2018

Some examples images pls? i want to take this issue

@AeliusSaionji
Copy link
Author

@jafjdev
Copy link

jafjdev commented May 17, 2018

i'll take it

@AeliusSaionji
Copy link
Author

AeliusSaionji commented May 17, 2018

Looks like it might be as simple as passing relevant flags to this function

private void applyFullScreen(boolean isFullScreen) {

@jafjdev
Copy link

jafjdev commented May 17, 2018

Oh! @AeliusSaionji this way?

if (isFullScreen) { getWindow().clearFlags(LayoutParams.FLAG_FULLSCREEN); getWindow().getDecorView().setSystemUiVisibility(uiOptions);

@AeliusSaionji
Copy link
Author

I don't actually know android/java development, I just saw that function has FLAG_FULLSCREEN, which the documentation references as one of the fullscreen modes.

@jafjdev
Copy link

jafjdev commented May 17, 2018

setSystemUiVisibility requeries android API 11, we're currently in API 8

@uberspot
Copy link
Owner

If you make sure everything else works and want to do a PR to increase the API version to support android 4.0+ then that's perfectly reasonable and I'd be happy to review it, offer feedback and merge it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants