Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpinBox? #534

Open
Feichtmeier opened this issue Jan 16, 2023 · 5 comments
Open

SpinBox? #534

Feichtmeier opened this issue Jan 16, 2023 · 5 comments
Labels
enhancement New feature or request widgets

Comments

@Feichtmeier
Copy link
Member

Using JPs spinbox in settings works good 👍

grafik

It just does not look like the same style than the yaru widgets anymore. Should there be a widget here or on JPs repo for this?

@Jupi007
Copy link
Member

Jupi007 commented Jan 16, 2023

I think it would be a good idea to have that kind of widget here, with our own style.

@jpnurmi
Copy link
Member

jpnurmi commented Jan 16, 2023

Heh, that widget was one of the first custom Flutter widgets I ever wrote and needs some serious refactoring. :D Or perhaps even better to start from scratch and only take some inspiration.

@Jupi007
Copy link
Member

Jupi007 commented Jan 16, 2023

If it is that old, maybe redo something brand new here :D
What was the features?

@jpnurmi
Copy link
Member

jpnurmi commented Jan 16, 2023

Hmm, I did experiment with a controller last summer: ubuntu-flutter-community/flutter_spinbox#60

It would be actually a lot easier to have a new refactored version here because then we don't need to support all those weird callbacks that people have contributed over the years. Those are the biggest pain to keep backwards compatibility with.

@Jupi007
Copy link
Member

Jupi007 commented Jan 16, 2023

It would be actually a lot easier to have a new refactored version here because then we don't need to support all those weird callbacks that people have contributed over the years. Those are the biggest pain to keep backwards compatibility with.

I just take a look at your repo, and I agree with you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request widgets
Projects
None yet
Development

No branches or pull requests

3 participants