Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyWB 2.7.x and resolve breaking changes #81

Open
anjackson opened this issue Apr 5, 2022 · 4 comments
Open

Update to PyWB 2.7.x and resolve breaking changes #81

anjackson opened this issue Apr 5, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@anjackson
Copy link
Contributor

There's a new PyWB on the way, with some significant changes: webrecorder/pywb#706

This includes e.g. moving the UI to Vue, which means it's likely that the ukwa-pywb theme modifications will break.

@anjackson anjackson added the enhancement New feature or request label Apr 5, 2022
@tw4l
Copy link
Contributor

tw4l commented Sep 21, 2022

The 2.7.0 release implements a new Vue banner and may (certainly open to opinions here!) drop the current default banner altogether.

If you'd like to move to the new banner, here's a sample of what styling it "out of the box" via config.yaml (specifying logos and colors per https://pywb.readthedocs.io/en/2.7.0-beta/manual/vue-ui.html) would look like:

image

There's also support for localization in the new banner, though it's not shown in the screenshot.

Making the change shouldn't be too difficult - we'll drop a few of the existing deprecated templates and static assets from ukwa-pywb, and modify the frame_insert.html template to use the Vue app without losing your GA keys and other customizations.

@tw4l
Copy link
Contributor

tw4l commented Sep 21, 2022

here's a snippet of the ui settings from config.yaml to get the above result:

ui:
    logo: ukwa-2018-w-sml.png
    navbar_background_hex: 2e6dd9
    navbar_color_hex: fff
    navbar_light_buttons: true

@tw4l
Copy link
Contributor

tw4l commented Sep 21, 2022

or with search bar centered (still working out the kinks of the new header layout):

image

@anjackson
Copy link
Contributor Author

Woah thank you for that! Looks nice!

@tw4l tw4l self-assigned this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants