Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming "setDefaultOptions" to "configureOptions" should replace "parent::setDefaultOptions" calls in body #23

Open
perk11 opened this issue Jan 26, 2016 · 5 comments
Assignees
Labels

Comments

@perk11
Copy link

perk11 commented Jan 26, 2016

Otherwise, there is an endless recursion in configureOptions.

@perk11 perk11 changed the title Renaming "setDefaultOptions" to "configureOptions" should replace "parent::setDefaultOptions" in body Renaming "setDefaultOptions" to "configureOptions" should replace "parent::setDefaultOptions" calls in body Jan 26, 2016
@umpirsky umpirsky self-assigned this Jan 26, 2016
@umpirsky
Copy link
Owner

Nice catch @perk11, thanks for reporting. 👍

@umpirsky umpirsky added the bug label Jan 26, 2016
@TomasVotruba
Copy link

@perk11 Hey, I'd like to include this feature, but I never used it this way.
Could please you provide before/after fix code, so I could understand it better?

Thanks

@aivus
Copy link
Contributor

aivus commented Oct 23, 2017

@TomasVotruba I think author means next:

Before

...
public function setDefaultOptions(OptionsResolverInterface $resolver) {
    parent::setDefaultOptions($resolver);
}
...

After:

...
public function configureOptions(OptionsResolver $resolver) {
    // Parent call renamed as well
    parent::configureOptions($resolver);
}
...

@TomasVotruba
Copy link

I see, thanks. I'll try to figure out what can I do with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants