-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a confirm delete dropdown to delete overrides #2245
Comments
I'm not sure here, it's not a critical piece, and deleting it on accident doesn't have many consequences. |
Yeah, maybe not a written modal like others. But a click-based confirm modal should do right? |
i am working on it . |
its not approved |
ok, no problem if this is approved then please assign me. |
yeah, I was thinking this too |
Sounds good to me. Can you remove the |
can you assign me this issue to me |
/assign |
Assigned to @biswa2005! Please open a draft PR linking this issue within 48h |
@chronark don't want to sound like this. But this should award me 50-150 points right? |
/award 150 |
Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
Preliminary Checks
I have reviewed https://unkey.com/docs for existing features that would solve my problem
I have searched for existing feature requests: https://github.com/unkeyed/unkey/issues
This issue is not a question, general help request, or anything other than a feature request directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.
Is your feature request related to a problem? Please describe.
Currently, if you try to delete overrides. It is immediately deleted. This might not be ideal as someone might miss-click it and have their override gone within a second.
https://app.unkey.com/ratelimits/namespaceId/overrides/
Describe the solution
Add a confirm modal like every other delete button to ask the user whether they want to delete their override before actually deleting it.
Describe alternatives you have considered (if any)
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: