Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirm delete dropdown to delete overrides #2245

Open
3 tasks done
harshsbhat opened this issue Oct 7, 2024 · 22 comments
Open
3 tasks done

Add a confirm delete dropdown to delete overrides #2245

harshsbhat opened this issue Oct 7, 2024 · 22 comments
Assignees
Labels
Feature New feature or request

Comments

@harshsbhat
Copy link
Contributor

harshsbhat commented Oct 7, 2024

Preliminary Checks

Is your feature request related to a problem? Please describe.

Currently, if you try to delete overrides. It is immediately deleted. This might not be ideal as someone might miss-click it and have their override gone within a second.

https://app.unkey.com/ratelimits/namespaceId/overrides/

Describe the solution

Add a confirm modal like every other delete button to ask the user whether they want to delete their override before actually deleting it.

Describe alternatives you have considered (if any)

No response

Additional context

No response

@harshsbhat harshsbhat added Feature New feature or request Needs Approval Needs approval from Unkey labels Oct 7, 2024
Copy link

linear bot commented Oct 7, 2024

@chronark
Copy link
Collaborator

chronark commented Oct 8, 2024

I'm not sure here, it's not a critical piece, and deleting it on accident doesn't have many consequences.

@harshsbhat
Copy link
Contributor Author

Yeah, maybe not a written modal like others. But a click-based confirm modal should do right?

@pragyananda
Copy link
Contributor

i am working on it .

@harshsbhat
Copy link
Contributor Author

i am working on it .

its not approved

@pragyananda
Copy link
Contributor

ok, no problem if this is approved then please assign me.

@chronark
Copy link
Collaborator

chronark commented Oct 9, 2024

Yeah, maybe not a written modal like others. But a click-based confirm modal should do right?

yeah, I was thinking this too
maybe turning the button into a dropdown with a single "confirm delete" action

@harshsbhat
Copy link
Contributor Author

harshsbhat commented Oct 9, 2024

Yeah, maybe not a written modal like others. But a click-based confirm modal should do right?

yeah, I was thinking this too maybe turning the button into a dropdown with a single "confirm delete" action

Sounds good to me. Can you remove the needs approval tag? @pragyananda wants to give a shot most likely

@chronark chronark changed the title Add a confirm delete modal to delete overrides Add a confirm delete dropdown to delete overrides Oct 11, 2024
@chronark chronark added 🕹️ oss.gg 🕹️ 150 points and removed Needs Approval Needs approval from Unkey labels Oct 11, 2024
@Aryant01
Copy link

can you assign me this issue to me

@biswa2005
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

Assigned to @biswa2005! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@harshsbhat
Copy link
Contributor Author

@chronark don't want to sound like this. But this should award me 50-150 points right?

@chronark
Copy link
Collaborator

/award 150

Copy link

oss-gg bot commented Oct 11, 2024

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

@ShreyasLakhani
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@roshan-29
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@Naresh-official
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@Navnit73
Copy link

/assign

Copy link

oss-gg bot commented Oct 13, 2024

This issue is already assigned to another person. Please find more issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants