Parameter.empty not preserved with &, |, ~ operators

[joelostblom]

What happened?

The following code works as expected:

click = alt.selection_point(empty=False)
ctrl_click = alt.selection_point(on='click[event.ctrlKey]', empty=False)

points = alt.Chart(data.cars.url).mark_point().encode(
    x='Horsepower:Q',
    y='Miles_per_Gallon:Q',
    fill=alt.condition(ctrl_click, alt.value('red'), alt.value('white')),
    size=alt.condition(click, alt.value(1000), alt.value(50))
).add_params(
    click, ctrl_click
)

points

Open the Chart in the Vega Editor

However, when changing the fill condition to include a parameter composition:

fill=alt.condition(ctrl_click & click, alt.value('red'), alt.value('white')),

The value empty=False is no longer respected for that encoding channel:

Open the Chart in the Vega Editor

In the VL spec you can see that this happens because Altair converts the parameter composition into the following VL:

"condition": {
  "test": {"and": [{"param": "param_208"}, {"param": "param_207"}]},
  "value": "red"
},

What would you like to happen instead?

The correct conversion to VL would look like this:

"condition": {
  "test": {"and": [{"param": "param_208", "empty": false}, {"param": "param_207", "empty": false}]},
  "value": "red"
},

Not sure how long this has been present, but as I show above it is not related to the resent introduction of when since it also happens with condition.

Minimal Repro

Composition operators only preserve Parameter.name

import altair as alt

click = alt.selection_point("click", empty=False)
ctrl_click = alt.selection_point("ctrl_click", on="click[event.ctrlKey]", empty=True)

>>> (click & ctrl_click).to_dict()
{'and': [{'param': 'click'}, {'param': 'ctrl_click'}]}

ctrl_click_false = alt.selection_point("ctrl_click_false", on="click[event.ctrlKey]", empty=False)

>>> (ctrl_click_false & ctrl_click).to_dict()
{'and': [{'param': 'ctrl_click_false'}, {'param': 'ctrl_click'}]}

Which version of Altair are you using?

• 5.4.1
• 5.6.0dev (17baaa2)

[dangotbanned]

This is unrelated to both condition and when.

All of these Parameter methods use Parameter.name only

• omitting Parameter.(empty|param|param_type):

altair/altair/vegalite/v5/api.py

Lines 391 to 421 in 62cd377

	def to_dict(self) -> dict[str, str | dict[str, Any]]:
	if self.param_type == "variable":
	return {"expr": self.name}
	elif self.param_type == "selection":
	nm: Any = self.name
	return {"param": nm.to_dict() if hasattr(nm, "to_dict") else nm}
	else:
	msg = f"Unrecognized parameter type: {self.param_type}"
	raise ValueError(msg)
	def __invert__(self) -> SelectionPredicateComposition | Any:
	if self.param_type == "selection":
	return SelectionPredicateComposition({"not": {"param": self.name}})
	else:
	return _expr_core.OperatorMixin.__invert__(self)
	def __and__(self, other: Any) -> SelectionPredicateComposition | Any:
	if self.param_type == "selection":
	if isinstance(other, Parameter):
	other = {"param": other.name}
	return SelectionPredicateComposition({"and": [{"param": self.name}, other]})
	else:
	return _expr_core.OperatorMixin.__and__(self, other)
	def __or__(self, other: Any) -> SelectionPredicateComposition | Any:
	if self.param_type == "selection":
	if isinstance(other, Parameter):
	other = {"param": other.name}
	return SelectionPredicateComposition({"or": [{"param": self.name}, other]})
	else:
	return _expr_core.OperatorMixin.__or__(self, other)

This should be preserved for param_type=="selection" https://vega.github.io/vega-lite/docs/predicate.html#selection-predicate - but appears to never have been in altair.