Graceful shutdown

[PepijnSenders]

Feature request

When next.js shuts down, it takes care of exiting the current process with code 0. This function does not close the HTTP server before it exits the process, next.js should make sure the server has been .close()d before exiting. We also need something for the case of people opening database connections and these being closed before the process exits.

This behavior is problematic in environments like kubernetes because the server is immediately shut down and will still be receiving requests as kubernetes replaces the pod. How this works is described quite well in detail here. We need to make sure that we can expose an endpoint where we signal that the pod should not be receiving any more requests, and make sure that after a set timeout the server gracefully shuts down. This is quite easy to implement with libraries like terminus.

Is your feature request related to a problem? Please describe.

Next.js doesn't shut down properly.

Describe the solution you'd like

A graceful shutdown solution to be added to the core project, with hooks to be able to shut down things like database connections.

Describe alternatives you've considered

This is easily fixed by adding a custom server, but I believe that this should be part of the core next.js code.

[banksalad-seongwoo]

To resolve it, I just opend this #29959

[airtoxin]

The graceful means, Stop accepting newly http connection, and completely end http request then shutting down server.
It is a good idea to execute the server.close() function after receiving the SIGTERM signal.
https://nodejs.org/api/net.html#serverclosecallback

[EmilioAiolfi]

@ijjk a doubt, is it possible to use "server.close()" of "Next Server"?
A new version 12.2.0 helps, but how I can be use server.close() ou another approach

// pages/_document.js
if (process.env.NEXT_MANUAL_SIG_HANDLE) {
  // this should be added in your custom _document
  process.on('SIGTERM', () => {
    console.log('Received SIGTERM: ', 'cleaning up')
    process.exit(0)
  })
  process.on('SIGINT', () => {
    console.log('Received SIGINT: ', 'cleaning up')
    process.exit(0)
  })
}

[finkrer]

@ijjk After #36909 we can write our own hooks for SIG events, but there's still no way to gracefully shutdown the Next server itself. Next just doesn't expose the server unless you use a custom one.

I really think the Next server should do this on its own, by default — without any user hooks. We just found that Next is leaving requests unanswered during restarts, most people probably won't notice that, but the problem is still there.

[vamcs]

@finkrer it sounds like you need to configure the keep-alive timeout for the server, take a look: https://nextjs.org/docs/api-reference/cli#keep-alive-timeout.

I'm also investigating how to correctly implement graceful shutdowns without a custom server, and I happened to find that page in the docs. We use a load balancer so I believe it should be enough for my case since we don't open DB connections or do anything that needs cleaning up before closing the server.

[finkrer]

Hi @vamcs.

As far as I understand, this setting would not help. The issue is that upon receiving the terminate signal Next just quits, while the timeout setting affects Next timing out connections while it's running.

Besides, I have tried using this setting before just in case since we are also using a reverse proxy, and it just broke the application outright. I think we were getting 502 errors from nginx.

[jmkng]

Using Next.js for a full stack project is hard to stomach when simple stuff like this is hard to access. This is just a big red flag.

[azerum]

I though that calling process.exit() if often unnecessary, as Node should shutdown by itself when there's no pending work left. It's also mentioned in the Node docs:

Calling process.exit() will force the process to exit as quickly as possible even if there are still asynchronous operations pending that have not yet completed fully, including I/O operations to process.stdout and process.stderr.

In most situations, it is not actually necessary to call process.exit() explicitly. The Node.js process will exit on its own if there is no additional work pending in the event loop. The process.exitCode property can be set to tell the process which exit code to use when the process exits gracefully.

Is there any specific reason why Next uses process.exit() instead of graceful shutdown?

[CaseyHaralson]

It looks like this commit might have implemented it: c5a8e09 (packages/next/src/server/lib/start-server.ts line 192)

[nebarf]

Looking at the implementation it does call process.exit immediately after server.close without waiting for existing connections to be ended. server.close is async (doc https://nodejs.org/api/net.html#serverclosecallback)

[lukevers]

Linking my comment here from another thread I added -- #51404 (comment)

This works locally, but I haven't tried it in production yet:

const process = require('process');
const spawn = require('child_process').spawn;

// Adding `detatched: true` makes sure the signal doesn't send down automatically
const server = spawn('pnpm', ['run', 'start'], { detached: true });
server.stdout.on('data', function(data) {
  process.stdout.write(data);
});

server.stderr.on('data', function (data) {
  process.stderr.write(data);
});

server.on('exit', function (code) {
  console.log('Application exited with code:', code.toString());
});

['SIGTERM', 'SIGINT'].forEach((signal) => {
  process.on(signal, function (signal) {
    console.log('Caught signal', signal, '-- Allowing requests to drain');

    setTimeout(() => {
      console.log('Terminating Application')
      server.kill(signal);
    }, 15 * 1000);

    setTimeout(function() {
      console.log('Terminating Wrapper');
      process.exit(0);
    }, 20 * 1000);
  });
});

[ryuichi1208]

Do you think the issue discussed in this Discussion has been resolved by the merge of the following PR? #60059