Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mangling is disabled for dev runtime builds #75297

Merged
merged 4 commits into from
Jan 25, 2025

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 24, 2025

Just ensures we keep mangling behavior prior to #75294

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 24, 2025
@ijjk ijjk requested a review from unstubbable January 24, 2025 22:47
@ijjk
Copy link
Member Author

ijjk commented Jan 24, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
buildDuration 19.4s 16.8s N/A
buildDurationCached 15.8s 12.9s N/A
nodeModulesSize 389 MB 392 MB ⚠️ +2.9 MB
nextStartRea..uration (ms) 443ms 447ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
5306-HASH.js gzip 54.1 kB 54.1 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.46 kB 5.46 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.6 kB 34.6 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.59 kB 4.58 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.35 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
_buildManifest.js gzip 748 B 747 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
index.html gzip 524 B 524 B
link.html gzip 539 B 538 B N/A
withRouter.html gzip 520 B 520 B
Overall change 1.04 kB 1.04 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 210 kB 210 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
middleware-b..fest.js gzip 670 B 666 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
app-page-exp...dev.js gzip 308 kB 385 kB ⚠️ +76.5 kB
app-page-exp..prod.js gzip 131 kB 131 kB
app-page-tur..prod.js gzip 144 kB 144 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page.run...dev.js gzip 300 kB 372 kB ⚠️ +72.4 kB
app-page.run..prod.js gzip 128 kB 128 kB
app-route-ex...dev.js gzip 31.8 kB 39.4 kB ⚠️ +7.61 kB
app-route-ex..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 25 kB 25 kB
app-route-tu..prod.js gzip 24.8 kB 24.8 kB
app-route.ru...dev.js gzip 33.1 kB 41 kB ⚠️ +7.93 kB
app-route.ru..prod.js gzip 24.8 kB 24.8 kB
dist_client_...dev.js gzip 314 B 326 B N/A
dist_client_...dev.js gzip 307 B 318 B N/A
pages-api-tu..prod.js gzip 8.81 kB 8.81 kB
pages-api.ru...dev.js gzip 9.82 kB 11.5 kB ⚠️ +1.66 kB
pages-api.ru..prod.js gzip 8.8 kB 8.8 kB
pages-turbo...prod.js gzip 21.6 kB 21.6 kB N/A
pages.runtim...dev.js gzip 26.1 kB 31.3 kB ⚠️ +5.27 kB
pages.runtim..prod.js gzip 21.6 kB 21.6 kB
server.runti..prod.js gzip 73.7 kB 73.7 kB
Overall change 1.46 MB 1.64 MB ⚠️ +171 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js ijjk/disable-dev-mangling Change
0.pack gzip 2.1 MB 2.1 MB ⚠️ +2.19 kB
index.pack gzip 75.5 kB 74.7 kB N/A
Overall change 2.1 MB 2.1 MB ⚠️ +2.19 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for dist_client_..ntime.dev.js
@@ -1,2 +1,2 @@
-"use strict";exports.ids=["dist_client_dev_noop-turbopack-hmr_js"],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":function(e,t){function o(){}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"connect",{enumerable:!0,get:function(){return o}}),("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}};
+"use strict";exports.ids=["dist_client_dev_noop-turbopack-hmr_js"],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":function(module,exports1){function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
 //# sourceMappingURL=dist_client_dev_noop-turbopack-hmr_js-experimental.runtime.dev.js.map
\ No newline at end of file
Diff for dist_client_..ntime.dev.js
@@ -1,2 +1,2 @@
-"use strict";exports.ids=["dist_client_dev_noop-turbopack-hmr_js"],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":function(e,t){function o(){}Object.defineProperty(t,"__esModule",{value:!0}),Object.defineProperty(t,"connect",{enumerable:!0,get:function(){return o}}),("function"==typeof t.default||"object"==typeof t.default&&null!==t.default)&&void 0===t.default.__esModule&&(Object.defineProperty(t.default,"__esModule",{value:!0}),Object.assign(t.default,t),e.exports=t.default)}};
+"use strict";exports.ids=["dist_client_dev_noop-turbopack-hmr_js"],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":function(module,exports1){function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
 //# sourceMappingURL=dist_client_dev_noop-turbopack-hmr_js.runtime.dev.js.map
\ No newline at end of file
Diff for pages-api.runtime.dev.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Commit: a2dfe4d

@ijjk ijjk requested a review from eps1lon January 24, 2025 23:02
@unstubbable unstubbable force-pushed the ijjk/disable-dev-mangling branch from c6bd152 to d6a37bd Compare January 24, 2025 23:34
@unstubbable unstubbable force-pushed the ijjk/disable-dev-mangling branch from d6a37bd to df845a3 Compare January 24, 2025 23:39
@ijjk ijjk enabled auto-merge (squash) January 25, 2025 00:20
@ijjk ijjk merged commit 98b0700 into canary Jan 25, 2025
130 checks passed
@ijjk ijjk deleted the ijjk/disable-dev-mangling branch January 25, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants