Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation for Views #170

Open
gmuraru opened this issue Feb 22, 2020 · 3 comments
Open

Separation for Views #170

gmuraru opened this issue Feb 22, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gmuraru
Copy link
Collaborator

gmuraru commented Feb 22, 2020

Currently, all the views are in the same file

Separate those views to one file each and maybe add one more layer of separation for views that a TA can see and views that a student can view.

@gmuraru gmuraru added enhancement New feature or request good first issue Good for newcomers labels Feb 22, 2020
@mgax
Copy link
Contributor

mgax commented Feb 23, 2020

Separate those views to one file each

That feels a bit excessive. I'm ok with separating student vs TA views. If you're concerned the views module has too much code, we could move some of the logic to other files, e.g. this chunk in the done view could be moved to /interface/backend/submission.py; also, this chunk looks like it should just call out to get_last_submissions_of_every_user.

@gmuraru
Copy link
Collaborator Author

gmuraru commented Feb 24, 2020

Hmm - you are right. I was thinking to have a little separation between what "this" should do and what "that" should do -- but still it is blurry what "this" and "that" should mean.

@gmuraru
Copy link
Collaborator Author

gmuraru commented Oct 3, 2020

We will have:

  • student_views.py
  • ta_views.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants