Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java SDK testConnection additional latency of ~1min added #359

Closed
ahmed-sadak opened this issue Mar 11, 2024 · 4 comments · Fixed by #398
Closed

Java SDK testConnection additional latency of ~1min added #359

ahmed-sadak opened this issue Mar 11, 2024 · 4 comments · Fixed by #398
Labels
bug Something isn't working
Milestone

Comments

@ahmed-sadak
Copy link
Contributor

Describe the bug

A JDK-based management pack with Integration SDK: when mp-test with 'test connection' is executed and the actual time taken is around 30-60s above the time taken inside both Java main method executions for 'get endpoints' and 'test connection' combined together

Reproduction steps

  1. Write a JDK-based mgmt pack which makes an additional call to an external system
  2. Try mp-test and connect to that external system
  3. With my example 'get endpoints' takes about 5 secs inside the main method in Java
  4. 'test connection' takes about 16 secs inside the main method in Java
  5. The above times out
  6. Test with 'mp-test connect -t 90' which takes around 75 seconds -> looks like some minute or so is added by the framework and Python server
    ...

Expected behavior

Expected behaviour is that there is not much additional delay apart from the actual execution of the Java main methods

Additional context

No response

@ahmed-sadak ahmed-sadak added the bug Something isn't working label Mar 11, 2024
@TrueFiskibility
Copy link
Contributor

@ahmed-sadak I am curious, how did you determine the times you've listed here? (5 seconds for get endpoints, 16 seconds for test connection)

@ahmed-sadak
Copy link
Contributor Author

I measured the 5 seconds for 'get endpoint' and 16 secs for 'test connection' from the entry in main() method until the exit while I had configured higher total timeout through mp-test in order to not shut down the process.

@TrueFiskibility
Copy link
Contributor

TrueFiskibility commented Mar 26, 2024

Ok, thanks. It sounds like you manually instrumented the code with logging in order to determine this timing. Is that correct?

@kjrokos kjrokos added this to the 1.2 milestone Jan 6, 2025
@TrueFiskibility
Copy link
Contributor

Nice work, Kyle! Thanks for addressing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants