Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why metrics do not export ScalarResources #3931

Open
yccharles opened this issue Dec 26, 2024 · 10 comments · May be fixed by #3937
Open

why metrics do not export ScalarResources #3931

yccharles opened this issue Dec 26, 2024 · 10 comments · May be fixed by #3937
Assignees
@zedongh
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/question Categorizes issue related to a new question

Comments

@yccharles
Copy link

Please describe your problem in detail

I can see only cpu and memory metrics :

queue_request_milli_cpu
queue_request_memory_bytes

I need more , such as :

queue_request_scalar_resources{resource="gpu"}

Any other relevant information

No response
@yccharles yccharles added the kind/question Categorizes issue related to a new question label Dec 26, 2024
@Monokaix
Copy link
Member

It's better to add scalar resources metrics.

@Monokaix
Copy link
Member

/good-first-issue

@volcano-sh-bot
Copy link
Contributor

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 27, 2024
@JesseStutler
Copy link
Member

It's a feature we needed. Welcome to contribute if you are ready!

@zedongh
Copy link
Contributor

zedongh commented Dec 29, 2024

/assign

@zedongh zedongh linked a pull request Dec 29, 2024 that will close this issue
Open
@JesseStutler
Copy link
Member

/area stable-metrics

@volcano-sh-bot
Copy link
Contributor

@JesseStutler: The label(s) area/stable-metrics cannot be applied. These labels are supported: ``

In response to this:

/area stable-metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JesseStutler
Copy link
Member

Do we need to carry these metrics as part of the default metrics of grafana? We now support displaying some default metrics when deploying grafana:
https://github.com/volcano-sh/volcano/blob/master/installer/helm/chart/volcano/templates/grafana.yaml#L60-L65

@yccharles
Copy link
Author

We also need export new metrics to describe each resource's capacity in a queue. Current there is no metrics about capacity metrics. @zedongh

maybe we need add 3 new metric just like this:

queue_capacity_milli_cpu
queue_capacity_memory_bytes
queue_capacity_scalar_resources

@zedongh
Copy link
Contributor

zedongh commented Jan 3, 2025

capacity

Will add later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zedongh zedongh

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/question Categorizes issue related to a new question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support scalar resources metric zedongh/volcano
5 participants
@zedongh @Monokaix @JesseStutler @volcano-sh-bot @yccharles