Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explainer incorrectly claims LCP reports the visual size of images #35

Closed
philipwalton opened this issue Aug 9, 2019 · 0 comments · Fixed by #38
Closed

Explainer incorrectly claims LCP reports the visual size of images #35

philipwalton opened this issue Aug 9, 2019 · 0 comments · Fixed by #38

Comments

@philipwalton
Copy link
Member

My understanding is LCP is supposed to factor in the intrinsic sizes of images and not consider the rendered size for LCP in cases where the image is stretched or enlarged (e.g. a 1px transparent gif).

The explainer, however, just mentions the visual size:
https://github.com/WICG/largest-contentful-paint#visual-size

It's also not clear from the spec that this is supposed to happen (see: w3c/element-timing#31).

The explainer should be updated to reflect the intention (and I believe the current Chrome implementation).

@npm1 npm1 changed the title Explains incorrectly claims LCP reports the visual size of images Explainer incorrectly claims LCP reports the visual size of images Aug 9, 2019
npm1 added a commit that referenced this issue Aug 14, 2019
@npm1 npm1 closed this as completed in #38 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant