Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec change: Globalextended attribute requires a value #650

Open
dontcallmedom opened this issue Jan 28, 2022 · 3 comments
Open

Spec change: Globalextended attribute requires a value #650

dontcallmedom opened this issue Jan 28, 2022 · 3 comments

Comments

@dontcallmedom
Copy link
Member

URL: whatwg/webidl#1088

(I didn't track the PR where the requirement itself was brought in, although I suspect it is not recent)

The Global extended attribute used to have its value optional, but it is now required.
In particular, https://github.com/w3c/webidl2.js/blob/529b40528dc8263a59a823b6b475b19414365dd3/test/invalid/idl/constructible-global.webidl is no longer valid WebIDL.

cc: @marcoscaceres @sidvishnoi for ReSpec
cc @tidoust

@saschanaz
Copy link
Member

Hmm, I don't think this is a breaking change in parser's perspective, right? I guess we can add a validation check though.

@dontcallmedom
Copy link
Member Author

I guess I'm not sure how the validation checks are integrated in the API surface of the package - it definitely means that previous-considered-valid content is no longer so.

(mostly, I just left the title in the issue as was suggested by the "WebIDL syntax change" template - again, not sure whether the micro-syntax of WebIDL extended attribute is considered part of the "WebIDL syntax :)

@saschanaz
Copy link
Member

Understood 👍

A new validation check is never a breaking change since the parser won't throw any exception but returns an array of validation messages, so I'll modify the title as such.

Thank you for reporting this!

@saschanaz saschanaz changed the title BREAKING CHANGE: Globalextended attribute requires a value Spec change: Globalextended attribute requires a value Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants