Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nwaku should be a submodule of status-go #3052

Closed
Ivansete-status opened this issue Sep 23, 2024 · 1 comment
Closed

chore: nwaku should be a submodule of status-go #3052

Ivansete-status opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
effort/days Estimated to be completed in a few days, less than a week

Comments

@Ivansete-status
Copy link
Collaborator

Ivansete-status commented Sep 23, 2024

Description

nwaku should be a submodule of status-go.

The status-go's feature/nwaku-in-status branch expects to have the following structure, which is so far being created/copied manually:
image.

Instead of doing that, we need to have a nwaku submodule, within status-go.

The libwaku.so should be compiled from within the status-go's Makefile. Notice that for libwaku.so to bring support to postgres, it should be compiled with make libwaku POSTGRES=1.

Once the new libwaku.so and libwaku.h location is defined, we will need to update the following paths to make it compile properly:
https://github.com/status-im/status-go/blob/94dc345d8ef5fb95fd855a665b1d32f3b0e32008/wakuv2/nwaku.go#L4-L7

@Ivansete-status Ivansete-status moved this to Priority in Waku Sep 23, 2024
@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Sep 23, 2024
@richard-ramos richard-ramos moved this from Priority to In Progress in Waku Oct 1, 2024
@richard-ramos
Copy link
Member

Implemented in status-im/status-go#5896.
I didn't add the POSTGRES=1 variable because it's likely that we wont need it as we're not starting a storenode within status-go. However in case it's necessary it can be added quickly to the Makefile

@richard-ramos richard-ramos moved this from In Progress to Code Review / QA in Waku Oct 1, 2024
@Ivansete-status Ivansete-status moved this from Code Review / QA to Done in Waku Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/days Estimated to be completed in a few days, less than a week
Projects
Archived in project
Development

No branches or pull requests

2 participants