Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tree Details - Bug] Maintenance Delete Maintenance Performed (Accidents) #559

Open
Tracked by #433
ri0nardo opened this issue Mar 8, 2023 · 5 comments
Open
Tracked by #433
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ri0nardo
Copy link

ri0nardo commented Mar 8, 2023

No description provided.

@zoobot
Copy link
Member

zoobot commented Mar 8, 2023

Maintenance buttons should be loaded for the day so they are "clicked" if previous maintenance was done that day. A user should be able to Unclick them and it will remove from history. Looks like this is currently broken though.
Fix here: #435

@zoobot zoobot added the bug Something isn't working label Mar 8, 2023
@ri0nardo
Copy link
Author

ri0nardo commented Mar 8, 2023

The solution I'm thinking of is

if we are going to go with a quick fix before we change the tree details container:

  • if maintenance has already occurred, the maintenance button text changes from "maintenance" to "modify maintenance" or something like that.
    • This would only be active for 24 hours? Then it will go back to saying "maintenance" for all users?
  • or we add a button for the tree history to modify session. This would then allow the user to delete or confirm changes?

if we want to add it into the new design:

  • once maintenance has been submitted, the tree maintenance icons would close and a message saying "thanks for caring for "TREE NAME". Under that text we have a button or linked text that would reopen the tree maintenance icons to modify the session. There would also be an additional button saying "delete session".
    • If "delete session" is selected, the user would then get to a screen asking "Do you really want to delete this session" which would lead to two buttons, "Yes delete" or "No, I want to keep this session".
  • Or we have it be modifiable from the tree history with a button stating "modify session". Which would lead to the same steps.
  • Or we only allow one of the two to be modifiable since they do the same function.

@zoobot
Copy link
Member

zoobot commented Mar 8, 2023

* if maintenance has already occurred, the maintenance button text changes from "maintenance" to "modify maintenance" or something like that.
  
  * This would only be active for 24 hours? Then it will go back to saying "maintenance" for all users?

YES! I like this message idea. :)

* Or we have it be modifiable from the tree history with a button stating "modify session". Which would lead to the same steps.

I like this one for deleting maintenance. Users can have the ability to delete their own maintenance history.

Thanks for your thoughtfulness on this!!

@ri0nardo ri0nardo moved this from In Progress to Help Wanted in Water the Trees Mar 8, 2023
@ri0nardo ri0nardo added the help wanted Extra attention is needed label Mar 8, 2023
@ri0nardo
Copy link
Author

ri0nardo commented Mar 8, 2023

Modified Maintenance Delete
Modified Maintenance Deleted

@ri0nardo
Copy link
Author

ri0nardo commented Mar 8, 2023

Maintenance Button to change to "Modify Maintenance" when session completed for 24 hours. After that the button changes back to to "maintenance" with a tree.

maintenance

@ri0nardo ri0nardo changed the title [Tree Details - Design] Maintenance Delete Maintenance Performed (Accidents) [Tree Details - Bug] Maintenance Delete Maintenance Performed (Accidents) Mar 8, 2023
@ri0nardo ri0nardo removed their assignment Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: Help Wanted
Development

No branches or pull requests

2 participants