Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use private API endpoint for public collections in dashboard #2321

Open
SuaYoo opened this issue Jan 20, 2025 · 0 comments · Fixed by #2324
Open

Use private API endpoint for public collections in dashboard #2321

SuaYoo opened this issue Jan 20, 2025 · 0 comments · Fixed by #2324
Assignees
@SuaYoo
Labels
front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Jan 20, 2025

The org dashboard currently uses the same public API endpoint as the public org profile. If the org itself is not public, the endpoint doesn't return any collections. The org dashboard should use the private collections endpoint with the access filter instead.
@SuaYoo SuaYoo added the front end Requires front end dev work label Jan 20, 2025
@SuaYoo SuaYoo self-assigned this Jan 20, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Jan 20, 2025
@SuaYoo SuaYoo moved this from Todo to Ready in Webrecorder Projects Jan 20, 2025
@SuaYoo SuaYoo moved this from Ready to Implementing in Webrecorder Projects Jan 20, 2025
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Jan 21, 2025
@SuaYoo SuaYoo mentioned this issue Jan 21, 2025
Merged
ikreymer pushed a commit that referenced this issue Jan 22, 2025
@SuaYoo @tw4l
feat: Update collection sorting & metadata (#2324)
273648b 
- Fixes #2321
- Resolves #2323

Follows #2327, should be
rebased and merged afterwards

## Changes

- Refactors dashboard and org profile preview to use private API
endpoint, to fix public collections not showing the org visibility is
hidden
- Enables sorting collections by `dateLatest`, sorts public collections
by `dateLatest` by default
- Enables sorting collections by page count
- Shows collection period (i.e. `dateEarliest` to `dateLatest`) in
collections list
- Shows same collection metadata in private and public views, updates
private view info bar
- Fixes "Update Org Profile" action item showing for crawler roles





<!-- ## Follow-ups -->

---------

Co-authored-by: Tessa Walsh <[email protected]>
SuaYoo added a commit that referenced this issue Jan 22, 2025
@SuaYoo @tw4l
feat: Update collection sorting & metadata (#2324)
09387f5 
- Fixes #2321
- Resolves #2323

Follows #2327, should be
rebased and merged afterwards

## Changes

- Refactors dashboard and org profile preview to use private API
endpoint, to fix public collections not showing the org visibility is
hidden
- Enables sorting collections by `dateLatest`, sorts public collections
by `dateLatest` by default
- Enables sorting collections by page count
- Shows collection period (i.e. `dateEarliest` to `dateLatest`) in
collections list
- Shows same collection metadata in private and public views, updates
private view info bar
- Fixes "Update Org Profile" action item showing for crawler roles





<!-- ## Follow-ups -->

---------

Co-authored-by: Tessa Walsh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
front end Requires front end dev work
Projects
Webrecorder Projects
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update collection sorting & metadata webrecorder/browsertrix
1 participant
@SuaYoo