Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Doesn't properly remove labels #13

Open
mxstbr opened this issue Jun 13, 2018 · 1 comment
Open

Doesn't properly remove labels #13

mxstbr opened this issue Jun 13, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@mxstbr
Copy link
Contributor

mxstbr commented Jun 13, 2018

Repro:

screen shot 2018-06-13 at 13 20 54

  1. Tick "WIP"
  2. Do some work
  3. Edit comment to untick "WIP" and tick "Ready for Review"
  4. The bot doesn't remove the old label
@mxstbr mxstbr added the bug Something isn't working label Jun 13, 2018
@thlmenezes
Copy link

thlmenezes commented Aug 12, 2022

I believe this bug comes from this line in uncheckedLabels reducer

    return [...labels, label]

the expected result of the repro for the code to work the "WIP" checkbox should match the label exactly, otherwise, the filter of current labels will not find the "WIP: Building"

Shouldn't it be rules.label instead?

Edit 1: worked just fine in my tests just now, so no clue no more, lol
maybe close the issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants