Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv2bufr in wis2box-api to add check_valid_location to avoid encoding incorrect location #808

Open
maaikelimper opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels
data transformation Data transformation enhancement New feature or request
Milestone

Comments

@maaikelimper
Copy link
Collaborator

csv2bufr in wis2box-api to add check_valid_location , this should throw error to alert users when location in csv deviates significantly from station-location.

need to determine reasonable margin of error

this has been requested by users and will resolve issues seen in the Zambia setup

@maaikelimper maaikelimper added enhancement New feature or request data transformation Data transformation labels Nov 21, 2024
@maaikelimper maaikelimper added this to the sprint-016 milestone Nov 21, 2024
@maaikelimper maaikelimper changed the title csv2bufr in wis2box-api to add check_valid_location to avoid csv2bufr in wis2box-api to add check_valid_location to avoid encoding incorrect location Nov 21, 2024
@maaikelimper maaikelimper self-assigned this Dec 9, 2024
@tomkralidis tomkralidis modified the milestones: sprint-016, sprint-017 Dec 19, 2024
@tomkralidis
Copy link
Collaborator

  • csv2bufr

    • if geometry def missing in mappings, set to missing.
    • if geometry def in mappings, set to missing
  • wis2box csv2bufr process

    • if geometry is missing from CSV, but data is in station metadata

    • add wis2box env var WIS2BOX_STATION_METADATA_FORCE_GEOMETRY=true|false

    • if CSV location differs from station metadata location

    • add wis2box env var WIS2BOX_OBSERVATION_GEOMETRY_THRESHOLD=10m|default

      • or we can add this in private wis2box metadata
      • compare CSV locations against station metadata locations
    • how do we handle moving stations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data transformation Data transformation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants