Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube streams occasionally freeze and don't recover properly. #609

Closed
akb825 opened this issue Mar 1, 2021 · 2 comments
Closed

YouTube streams occasionally freeze and don't recover properly. #609

akb825 opened this issue Mar 1, 2021 · 2 comments
Labels
Issue Type: Bug issue has reported a bug

Comments

@akb825
Copy link

akb825 commented Mar 1, 2021

When using the YouTube addon, streams occasionally freeze. After waiting for several seconds, either video will continue without audio or audio will continue without video. Seeking is also broken, and the only way to resume playback seems to be to stop and re-start the video.

I believe this is the relevant section of the log where the error occurred:

2021-02-28 16:24:43.622 T:4784     INFO <general>: CVideoPlayerAudio::Process - stream stalled
2021-02-28 16:24:56.762 T:4767    ERROR <general>: CCurlFile::FillBuffer - Failed: Timeout was reached(28)
2021-02-28 16:24:56.762 T:4767    ERROR <general>: AddOnLog: inputstream.adaptive: Download https://r2---sn-n4v7sn7s.googlevideo.com/videoplayback?expire=1614579422&ei=fjI8YPaSKZrPkgbdvLrAAQ&ip=2600:8801:d800:537:5d28:2921:b247:45ed&id=o-AKAFqU_8yVUfL4fFYwjc6HXqZi6eyVNo2EVnBW7VvuxD&itag=140&source=youtube&requiressl=yes&mh=a9&mm=31,26&mn=sn-n4v7sn7s,sn-p5qlsnrl&ms=au,onr&mv=m&mvi=2&pl=33&initcwndbps=1777500&vprv=1&mime=audio/mp4&ns=EqPnrC974onp9pBY2n1KEc4F&gir=yes&clen=25598378&dur=1581.673&lmt=1541189081301721&mt=1614557548&fvip=2&keepalive=yes&c=WEB&txp=2311222&n=Iu-DhZWzCHPUskkjFf&sparams=expire,ei,ip,id,itag,source,requiressl,vprv,mime,ns,gir,clen,dur,lmt&sig=AOq0QJ8wRAIgYki1NHLmxq2X5fYPP0Ie_KCz9Zu-Yd5MWN7EE5e6PQQCIGyZA-tgy4SU63ZsLUT8GX_nRl8msfDs2n_dxH3-1Coh&lsparams=mh,mm,mn,ms,mv,mvi,pl,initcwndbps&lsig=AG3C_xAwRAIgUyDFHO5tBBvXWecWm7KgudGzfQ0ArulnPBmjkVG36FYCIB7GAJGy77bgtw4Tf2NCt7gGhnVZArghD34yXSBiwYOQ doesn't provide any data: invalid
2021-02-28 16:24:57.687 T:4784     INFO <general>: CVideoPlayerAudio::Process - stream stalled
2021-02-28 16:24:57.699 T:4766  WARNING <general>: OutputPicture - timeout waiting for buffer
2021-02-28 16:24:57.704 T:4759     INFO <general>: AddOnLog: inputstream.adaptive: PosTime (472057)
2021-02-28 16:24:57.989 T:4759     INFO <general>: AddOnLog: inputstream.adaptive: seekTime(472.1) for Stream:1 continues at 476.3 (PTS: 476283333)

If there's an error retrieving the stream data I could understand there being a hiccup in playback, but I would expect it to gracefully recover without having to restart the video.

This could potentially be related to #583. Based on the issue and linked PR that issue was due to an HTTP error and the solution is to retry on HTTP failures. This appears to be failing for the read, so it may need to be expanded to retrying on read failures.

@glennguy
Copy link
Contributor

glennguy commented Mar 4, 2021

Yes looks to be the same issue as 583, hard to know exactly from the non-debug log snippet.
But yes if a stream fails to download a segment at some point then this is the current behavior. Ideally a more robust solution such as in #594 would be better IMO as there's currently no mechanism to recover in the future, those streams are gone forever.

@CastagnaIT CastagnaIT added the Issue Type: Bug issue has reported a bug label Nov 28, 2021
@CastagnaIT
Copy link
Collaborator

this problem apparently related to failed downloads due to missing retry, has been already fixed on Kodi 20
but the incomplete log attached is not useful to understand something
if still happens suggest you to open a new Issue by providing full info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue Type: Bug issue has reported a bug
Projects
None yet
Development

No branches or pull requests

3 participants