Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support searching and matching with perl-like regexes. #1

Open
ethercrow opened this issue Oct 19, 2014 · 3 comments
Open

Support searching and matching with perl-like regexes. #1

ethercrow opened this issue Oct 19, 2014 · 3 comments

Comments

@ethercrow
Copy link
Member

ethercrow commented Oct 19, 2014

Since we already depend on text-icu.

Update 2017-09-09: We don't anymore.

@Fuuzetsu
Copy link
Member

The regex stuff exposed by ICU is not thread-safe and has a poor interface: close to everything runs in IO. Further, I don't think there is any optimisation we can do with working on the underlying rope structure anyway for this kind of task so I don't think it makes much sense to stick this functionality in here.

@ethercrow
Copy link
Member Author

Can we trust any other regex library to handle unicode properly?

@Fuuzetsu
Copy link
Member

We only use ICU to decode/encode the file contents, in the end it all goes to Text so anything that works over Text should do fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants