Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce value and item price/discount #262

Open
jochemep opened this issue Dec 20, 2024 · 3 comments
Open

Ecommerce value and item price/discount #262

jochemep opened this issue Dec 20, 2024 · 3 comments

Comments

@jochemep
Copy link

Hi @jissereitsma,

I am currently testing version 3.9.12 for a project. Unfortunately, the implementation is not yet correct.

As an example, I will use the purchase event along with its accompanying documentation, but much of this also applies to other events.

The parameter value is incorrect when a cart discount (discount code) is active. Value reflects the price before the discount, but it should reflect the price after the discount. It is already exclusive of VAT, which is correct.

The item parameter price should be exclusive of VAT and discount. Currently, it is still inclusive of VAT, and when a cart discount is applied, it also includes the discount (whether this is possible or necessary, I cannot say.). The discount can be included in the item parameter discount.

At this moment, it is impossible with the current data layer to pass the correct purchase value to GA4 and Google Ads when a cart discount is applied.

I hope this information is helpful. Let me know if you have any further questions about this.

@jissereitsma
Copy link
Collaborator

Could you perhaps work on a PR for this? I currently lack the time to work on this. Note that this is just a voluntary project to help people with a free transparent GTM extension. If you make money with Magento, collaboration is appreciated here.

@jissereitsma
Copy link
Collaborator

And note that version 3.9.12 is outdated.

@jochemep
Copy link
Author

jochemep commented Jan 6, 2025

Hi @jissereitsma ,

Thank you for your response, and I completely understand that you're asking for help. Unfortunately, I’m not a (Magento) developer myself. I work as a marketer on a project that uses your valuable GTM module. I’ll ask the merchant if they can update the module and have the web developer create a PR. Please see this feedback as my contribution to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants