Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency job ids handling #100

Open
1 task done
iLLiCiTiT opened this issue Jan 7, 2025 · 1 comment
Open
1 task done

Dependency job ids handling #100

iLLiCiTiT opened this issue Jan 7, 2025 · 1 comment

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Jan 7, 2025

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Please describe the feature you have in mind and explain what the current shortcomings are?

Usually publish job does have dependency on render job. But there might be more than one render job for singlt publish. We also do store the job ids to the metadata file, which is then read by ayon-core plugin, which "requires" {"job": {"_id": ...}} to be available in metadata file -> this should not be requirement and ayon-core should not know about the key.

Suggested implementation?

  1. Change ayon-core to not require "job" key in metadata file, and the same plugin should get from the metadata file key, where "job processor metadata" are stored, and store it to instance data both with pre-defined key (via constant) -> name of the key is questionable, it must not be deadline specific, e.g. "addon_metadata" (I don't know).
  2. Deadline does expect that there might be more than one dependent job and unify the key where the job ids are stored. There is option to have multiple dependency ids, but all are using different keys, that are based on different conditions.
  3. Deadline still fills 'job' for backwards compatibility but also does store all dependency ids to the new pre-defined key.

Describe alternatives you've considered:

No response

@iLLiCiTiT
Copy link
Member Author

Created PR in ayon-core to not require "job" and store metadata content to instance data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant