Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AY-7342_Nuke: write nodes path doesn't recalculate #55

Open
ynbot opened this issue Jan 21, 2025 · 4 comments · May be fixed by #58
Open

AY-7342_Nuke: write nodes path doesn't recalculate #55

ynbot opened this issue Jan 21, 2025 · 4 comments · May be fixed by #58
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working

Comments

@ynbot
Copy link
Contributor

ynbot commented Jan 21, 2025

Please describe the issue you have encountered?

Path where Write node will render stays same after creation. This would cause an issue if it should be filled with custom staging dir template that contains {version} , eg if it should be rendering into versioned location.

This affects both local and farm renders.

How to replicate the issue?

No response

Additional context:

link to discussion on Discord
(might be a private channel)

This issue was automatically created from Clickup ticket AY-7342

@ynbot ynbot added sponsored This is directly sponsored by a client or community member type: bug Something isn't working labels Jan 21, 2025
@jakubjezek001
Copy link
Member

Just to add some more info for the design solution:

  • callback is already available in ayon-nuke\client\ayon_nuke\api\lib.py called writes_version_sync which could be utilised for this workflow
  • callback should be triggered either with addOnScriptSave or with addOnScriptLoad but we need to make sure that we optimise the process as much as possible so it is not slowing down users work flow.
  • workfile version should always be in sync with render product which are having {version} in custom staging template if it is used in the filepath knob.
  • It should either be next published version if Follow Workfile Version is not set. If it is then it should be workfile version.
  • we need to make sure the switch between workfile version or next available version is also followed in product node creation.

@tweak-wtf
Copy link

  • callback should be triggered either with addOnScriptSave or with addOnScriptLoad but we need to make sure that we optimise the process as much as possible so it is not slowing down users work flow.

I think we should use addOnScriptLoad to only let this run once as workfile versions won't be changing in a running session imho

  • workfile version should always be in sync with render product which are having {version} in custom staging template if it is used in the filepath knob.
  • It should either be next published version if Follow Workfile Version is not set. If it is then it should be workfile version.
  • we need to make sure the switch between workfile version or next available version is also followed in product node creation.

this would mean that in order to render into a versioned work drive a user would need to enable Follow Workfile Version and configure a custom staging dir correct?

@jakubjezek001
Copy link
Member

I think we should use addOnScriptLoad to only

yes you are right.

this would mean that in order to render into a versioned work drive a user would need to enable Follow Workfile Version and configure a custom staging dir correct?

If I understand correctly the therm versioned work drive then actually this will be added to it always - depending on the custom staging dir template and the preset which is leading to the template. So if we assume that the product in the scene is having its counterpart in custom staging dir profiles and the template is leading to the versioned work drive then no matter if the Follow Workfile Version is set or not, the renders will endup in the drive.

@kalisp
Copy link
Member

kalisp commented Jan 22, 2025

I added this update in #58 to collect_writes with protection for frames* workflows. (I didnt use callback as I didn't know about it, I will use it.

I find changing it in publish more visible (with some logging), than to have it hidden after some event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants