fix: increase zeebe cpu limit to 1.7 in default benchmark #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entangled90
force-pushed
the
cs-bump-cpu-limit-on-default-benchmark
branch
from
73332b2 to
4d027f5
Compare
npepinpe
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
I don't know if we want to recreate the existing benchmarks. On one hand, it would be good to keep things consistent to avoid confusion for future medics - on the other, they're currently suffering a little bit, and we may want to look into investigating why.
Can you check with the current medic (Lena) and see if there's any use in keeping the existing benchmarks for investigation (i.e. anything to learn), or if we just recreate them once we released the chart with these new defaults?
|
I checked with Lena and we agreed that it's probably better to restart them all and check if there is a cpu regression after we restarted them, in order to have less noise in the investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the cpu limits in the default benchmark to match the limits in the realistic one