Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Invalid 'resource' item in resource metric group storagegroup-resource in metrics file: console.storagegroup #379

Closed
vmorris opened this issue Sep 19, 2023 · 3 comments · Fixed by #411 or #412

Comments

@vmorris
Copy link

vmorris commented Sep 19, 2023

Describe the bug
zhmc exporter gets to the end of enabling auto-update for LPARs, and then Errors

Sep 19 17:04:22 s390-kvm-metrics zhmc_prometheus_exporter[1192568]: Enabling auto-update for LPAR P0095FA8.L59
Sep 19 17:04:24 s390-kvm-metrics zhmc_prometheus_exporter[1192568]: Retrieving resources from the HMC for resource metric group partition-resource
Sep 19 17:04:24 s390-kvm-metrics zhmc_prometheus_exporter[1192568]: Retrieving resources from the HMC for resource metric group storagegroup-resource
Sep 19 17:04:24 s390-kvm-metrics zhmc_prometheus_exporter[1192568]: Error: Invalid 'resource' item in resource metric group storagegroup-resource in metrics file: console.storagegroup

Expected behavior
exporter does not exit

To Reproduce
Unknown.. this is a z16 machine, and I'm using the latest version v1.4.2 of the exporter.

Environment information

  • Output of zhmc_prometheus_exporter --version: v1.4.2
  • HMC version: 2.16.0

Command output
<-- Relevant parts of the command output. If possible, with '-vv'. -->

Log file
<-- If possible, attach a log file generated with '--log-comp all=debug --log exporter.log'. -->

@andy-maier
Copy link
Member

andy-maier commented Nov 9, 2023

Hi Vance. Sorry for the delay.

It seems you are using a metrics.yaml file from 1.5.0 dev with an exporter 1.4.2.
Please fall back to the metrics.yaml file from 1.4.2 (e.g. https://github.com/zhmcclient/zhmc-prometheus-exporter/blob/stable_1.4/examples/metrics.yaml).

Let me know if that helps.

It would also be good probably to reduce the severity of the error to a warning so that the exporter would continue, and maybe to add a hint about the file version.

@andy-maier andy-maier self-assigned this Nov 9, 2023
@andy-maier andy-maier added the resolution: invalid This doesn't seem right label Nov 9, 2023
@andy-maier andy-maier added this to the 1.5.0 milestone Nov 9, 2023
@andy-maier andy-maier added type: enhancement New feature or request area: code and removed resolution: invalid This doesn't seem right labels Nov 9, 2023
@andy-maier andy-maier linked a pull request Nov 9, 2023 that will close this issue
@andy-maier andy-maier linked a pull request Nov 9, 2023 that will close this issue
@andy-maier
Copy link
Member

I have PRs up that change the error into a warning that is displayed, and then the exporter continues.

@vmorris
Copy link
Author

vmorris commented Nov 10, 2023

Thanks @andy-maier - I just switched the yaml to the correct version and it's working well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment