Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError when using 'storage_groups' on 'Client' object #540

Closed
andy-maier opened this issue Jul 29, 2024 · 0 comments · Fixed by #541 or #542
Closed

AttributeError when using 'storage_groups' on 'Client' object #540

andy-maier opened this issue Jul 29, 2024 · 0 comments · Fixed by #541 or #542
Assignees
@andy-maier
Labels
area: code resolution: fixed rollback done type: bug Something isn't working
Milestone
1.7.0

Comments

@andy-maier
Copy link
Member

andy-maier commented Jul 29, 2024 •
edited
Loading 

Ignoring label 'value' on metric with exporter name 'storage_groups' due to error when rendering the Jinja2 expression in the label value: AttributeError: 'Client' object has no attribute 'storage_groups'

Reason is that the code introduced in PRs #457 (in 1.6.0) and #458 (rollback to 1.5.1) incorrectly accessed "storage_groups" on the Client object when it should have done that on the Console object.
@andy-maier andy-maier self-assigned this Jul 29, 2024
@andy-maier andy-maier added this to the 1.7.0 milestone Jul 29, 2024
@andy-maier andy-maier linked a pull request Jul 29, 2024 that will close this issue
Fixed AttributeError when using 'storage_groups' on 'Client' object #541
Merged
@andy-maier andy-maier mentioned this issue Jul 29, 2024
Merged
@andy-maier andy-maier linked a pull request Jul 29, 2024 that will close this issue
1.6: Fixed AttributeError when using 'storage_groups' on 'Client' object #542
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy-maier andy-maier

Labels
area: code resolution: fixed rollback done type: bug Something isn't working
Projects
None yet
Milestone
1.7.0
1 participant
@andy-maier