Account Abstraction multisig deployment estimategas error

[ExtraCaterpiller]

Environment

Testnet

zkSolc Version

latest

zksync-ethers Version

6.10.0

Hardhat.config.ts

require("@nomicfoundation/hardhat-toolbox");
require("@matterlabs/hardhat-zksync")
require("dotenv").config()

/** @type import('hardhat/config').HardhatUserConfig */
module.exports = {
  zksolc: {
    version: "latest",
    settings: {
      enableEraVMExtensions: true,
    },
  },
  solidity: {
    version: "0.8.20",
    eraVersion: "1.0.0",
    settings: {
      optimizer: {
        enabled: true,
        runs: 200,
      },
    }
  },
  deployerAccounts: {
    'zkTestnet': 0,
    dafault: 0,
  },
  defaultNetwork: "zkSyncTestnet",
  networks: {
    hardhat: {
      zksync: true,
    },
    zkSyncTestnet: {
      url: "http://localhost:8011",
      ethNetwork: "localhost",
      zksync: true,
      chainId: 260
    },
    zkSyncSepoliaTestnet: {
      url: "https://sepolia.era.zksync.dev",
      ethNetwork: "sepolia",
      zksync: true,
      chainId: 300,
      verifyURL: "https://explorer.sepolia.era.zksync.dev/contract_verification",
    },
    dockerizedNode: {
      url: "http://localhost:3050",
      ethNetwork: "http://localhost:8545",
      zksync: true,
      chainId: 270
    },
    zkSyncMainnet: {
      url: "https://mainnet.era.zksync.io",
      ethNetwork: "mainnet",
      zksync: true,
      verifyURL: "https://zksync2-mainnet-explorer.zksync.io/contract_verification",
    },
  },
  gasReporter: {
    enabled: true,
    currency: 'USD',
    //outputFile: 'gas-reporter.txt',
    coinmarketcap: process.env.COINMARKETCAP_API_KEY
  },
};

Deployment Script (WITHOUT PRIVATE KEY)

const {ethers, network, userConfig, artifacts} = require("hardhat")
const { Wallet, utils, Provider, types, EIP712Signer } = require("zksync-ethers")
const addresses = require("../address.json")

const AA_FACTORY_ADDRESS = addresses[network.config.chainId]

module.exports = async () => {
    const provider = new Provider(userConfig.networks.zkSyncTestnet.url)
    //const provider = new Provider(userConfig.networks.zkSyncSepoliaTestnet.url)
    const wallet = new Wallet(process.env.RICH_ACCOUNTS_PRIVATE_KEY).connect(provider)
    //const wallet = new Wallet(process.env.WALLET_PRIVATE_KEY).connect(provider)
    
    const factoryArtifact = await artifacts.readArtifact("AAFactory")
    const aaFactory = new ethers.Contract(
        AA_FACTORY_ADDRESS,
        factoryArtifact.abi,
        wallet
    )
    
    const owner1 = Wallet.createRandom()
    const owner2 = Wallet.createRandom()
    
    const salt = ethers.ZeroHash;
    
    const tx = await aaFactory.deployAccount(salt, owner1.address, owner2.address, {gasLimit: BigInt("30000000")})
    await tx.wait()
    
    const abiCoder = new ethers.AbiCoder()
    const multisigAddress = utils.create2Address(
        AA_FACTORY_ADDRESS,
        await aaFactory.aaBytecodeHash(),
        salt,
        abiCoder.encode(['address', 'address'], [owner1.address, owner2.address])
    )

    console.log(`Multisig account deployed on address ${multisigAddress}`)
}

Package.json

{
  "name": "zksyncaccountabstraction",
  "version": "1.0.0",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "description": "",
  "devDependencies": {
    "@matterlabs/hardhat-zksync": "^1.1.0",
    "@matterlabs/hardhat-zksync-deploy": "^1.5.0",
    "@matterlabs/hardhat-zksync-ethers": "^1.1.0",
    "@matterlabs/hardhat-zksync-node": "^1.1.0",
    "@matterlabs/hardhat-zksync-solc": "^1.2.1",
    "@matterlabs/zksync-contracts": "^0.6.1",
    "@nomicfoundation/hardhat-toolbox": "^5.0.0",
    "@openzeppelin/contracts": "^4.6.0",
    "dotenv": "^16.4.5",
    "ethers": "^6.13.1",
    "hardhat": "^2.22.6",
    "zksync-ethers": "^6.10.0"
  }
}

Contract Code

AAFactory.sol-

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;

import "@matterlabs/zksync-contracts/l2/system-contracts/Constants.sol";
import "@matterlabs/zksync-contracts/l2/system-contracts/libraries/SystemContractsCaller.sol";

contract AAFactory {
    error AAFactory__AccountDeployerFailed();

    bytes32 public aaBytecodeHash;

    constructor(bytes32 _aaBytecodeHash) {
        aaBytecodeHash = _aaBytecodeHash;
    }

    function deployAccount(
        bytes32 _salt,
        address _owner1,
        address _owner2
    ) external returns (address accountAddress) {
        (bool success, bytes memory returnData) = SystemContractsCaller
            .systemCallWithReturndata(
                uint32(gasleft()),
                address(DEPLOYER_SYSTEM_CONTRACT),
                uint128(0),
                abi.encodeCall(
                    DEPLOYER_SYSTEM_CONTRACT.create2Account,
                    (
                        _salt,
                        aaBytecodeHash,
                        abi.encode(_owner1, _owner2),
                        IContractDeployer.AccountAbstractionVersion.Version1
                    )
                )
            );

        if (!success) {
            revert AAFactory__AccountDeployerFailed();
        }

        (accountAddress) = abi.decode(returnData, (address));
    }
}

### Does this work on other EVMs? (If yes, please list at least 1 of them)

no

### Description of What Your Contract Does

It's a multisig contract. I followed the multisig tutorial from the official community code. I used hardhat javascript to deploy it.

### Repo Link (Optional)

https://github.com/ExtraCaterpiller/AccountAbstraction-Demo-ZkSync

### Additional Details

I can deploy the contract factory correctly. But I am having issues at this function ```aaFactory.deployAccount``` . It reverts with this short message-"transaction execution reverted". When I do not use the ```{gasLimit: BigInt("30000000")}```, I get this in my terminal-
```code: 'CALL_EXCEPTION',
  action: 'estimateGas',
  data: '0xb0591126',
  reason: null,
  transaction: {
    to: '0x23b13d016E973C9915c6252271fF06cCA2098885',
    data: '0x76fb8b650000000000000000000000000000000000000000000000000000000000000000000000000000000000000000f19c3f8a891cb5a6311f2b75a8f4141d1e38f99d0000000000000000000000007d16b0fd979d6c993fbb081af0e172f1f03ddefc',
    from: '0xBC989fDe9e54cAd2aB4392Af6dF60f04873A033A'
  },
  invocation: null,
  revert: null,
  shortMessage: 'execution reverted (unknown custom error)',
  info: {
    error: {
      code: 3,
      message: 'execution reverted: Error function_selector = 0xb0591126, data = 0xb0591126',
      data: '0xb0591126'
    },
    payload: {
      method: 'eth_estimateGas',
      params: [Array],
      id: 4,
      jsonrpc: '2.0'
    }
  }
}

I am using local zksync node for testing.
I am new to blockchain. So, I would really appreciate any help. Thank you

[gleenai[bot]]

It appears that the issue you're encountering with the aaFactory.deployAccount function is related to gas estimation, which is a common challenge when deploying contracts, especially on test networks like zkSync. Here are a few steps and considerations that might help resolve the issue:

1. Gas Limit: You've already tried adjusting the gas limit manually. This is a good approach since sometimes the automatic gas estimation might not allocate enough gas for transactions that involve more complex operations or state changes. Ensure that the gas limit you set is sufficient to cover all operations within the contract method.

2. Check Contract Logic: Review the logic within your deployAccount function. The error might be due to how the contract handles or processes the data. Since the transaction reverts, it suggests that there might be conditions or assertions in your contract code that aren't met or are incorrectly handled.

3. Error Handling: The custom error AAFactory__AccountDeployerFailed() is triggered, indicating that the call to the system contract fails. This could be due to several reasons such as incorrect parameters passed to the system call, issues with the bytecode hash, or the salt and owner addresses used in the deployment.

4. Local zkSync Node: Since you are using a local zkSync node, ensure that it is fully synced and configured correctly. Sometimes, discrepancies in local node setups can lead to unexpected behaviors.

5. Debugging: Utilize Hardhat's debugging tools to trace the transaction execution. This can provide more insights into where exactly in the contract the transaction fails. You can use Hardhat's console.log in your Solidity code to output variable values and check the internal state at various points in your function.

6. Network Issues: Since you are on a testnet, network instability or specific testnet issues could also cause transactions to fail. Verify if there are any ongoing issues with the zkSync testnet you are using.

7. Consult Documentation and Community: Since you are following a tutorial, check if there are updates or errata that address issues similar to yours. Also, engaging with the zkSync developer community can provide insights and potential solutions based on similar experiences.

If after trying these steps the issue persists, consider providing more detailed logs and error messages to the zkSync developer community or seeking direct support from zkSync's development team.

Your feedback helps us serve you better. If this fully addresses your question, please give it a thumbs up. If it doesn't, please give it a thumbs down. This will inform the community and team so we can improve our support.

[ExtraCaterpiller]

It worked after I added "create" argument in the deploy function on my AAFactory deployment script-

const hre = require("hardhat")
const { Deployer } = require("@matterlabs/hardhat-zksync-deploy")
const { Wallet, utils } = require("zksync-ethers")
const fs = require("fs")
const path = require("path")

module.exports = async () => {
    const wallet = new Wallet(process.env.RICH_ACCOUNTS_PRIVATE_KEY)
    //const wallet = new Wallet(process.env.WALLET_PRIVATE_KEY)
    const deployer = new Deployer(hre, wallet)

    const aaFactoryArtifact = await deployer.loadArtifact("AAFactory")
    const aaTwoUserMultisig = await deployer.loadArtifact("TwoUserMultisigAA")
    
    const bytecodeHash = utils.hashBytecode(aaTwoUserMultisig.bytecode)

    console.log("-----------------------------------")
    
    const deploymentFee = await deployer.estimateDeployFee(aaFactoryArtifact, [bytecodeHash]);
    
    /* const depositHandle = await deployer.zkWallet.deposit({
        token: utils.ETH_ADDRESS,
        amount: deploymentFee * BigInt(2),
        to: deployer.zkWallet.address,
        });
    await depositHandle.waitL1Commit() */
    
    const parsedFee = ethers.formatEther(deploymentFee);
    console.log(`The deployment is estimated to cost ${parsedFee} ETH`);

    console.log("Deploying AAFactory...")
    const aaFactory = await deployer.deploy(
        aaFactoryArtifact,
        [bytecodeHash],
        "create",
        undefined,
        [aaTwoUserMultisig.bytecode,]
    )

    console.log("-------------------------------------")
    console.log(`AA factory address: ${await aaFactory.getAddress()}`);

    // Updating AAFactory address in address.json
    let addresses = {}

    try {
        addresses = require('../address.json')
    } catch (error) {
        console.error("Error reading existing address file:", error.message)
    }

    const chainId = hre.network.config.chainId
    addresses[chainId] = await aaFactory.getAddress()
    fs.writeFileSync(path.resolve(__dirname, "../address.json"), JSON.stringify(addresses, null, 2))
}

module.exports.tags = ["all", "factory"]