Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support globstar and extglob #6

Open
DrSensor opened this issue Jul 31, 2023 · 2 comments
Open

Support globstar and extglob #6

DrSensor opened this issue Jul 31, 2023 · 2 comments

Comments

@DrSensor
Copy link

DrSensor commented Jul 31, 2023 •
edited
Loading

Similar with GNU Make, I noticed that knit.glob() also doesn't support globstar and extglob too (e.g path/**/mangle-*.jsonc?). Is it intentional by design?
@zyedidia
Copy link
Owner

zyedidia commented Aug 1, 2023

I'm not opposed to including support for this, I think the glob library I'm using just doesn't support it fully. Maybe this library would support the types of patterns you want? https://github.com/bmatcuk/doublestar. I can look into replacing the current glob usage to use that library instead.

@DrSensor
Copy link
Author

DrSensor commented Aug 2, 2023 •
edited
Loading

Looks good to me as long as knit script enforce UNIX style path. Path separator must always be / instead of \ since that library will disable escaping if it's on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DrSensor @zyedidia