fix: use u64 in BaseSplitGenerator #1647
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BaseSplitGenerator was casting fields (which fit in
u64
) intousize
. This doesn't work in 32-bit architectures where usize is 32 bits, like wasm32. Keeping the value inu64
allows it to work in 32-bit architectures.We found this error while trying to run a recursive circuit in wasm, where the verification was failing. This issue can be easily tested on an amd64 linux machine by compiling with the target i686 and running the tests. Before this PR these are the tests that fail:
Note that I disabled jemalloc to be able to run in 32-bit mode.
After the fix all tests pass in 32-bit mode.