perf: Check for zero amount early in 'add_eth'

0xPolygonZero · Jun 24, 2024 · 6492246 · 6492246
1 parent baecefc
commit 6492246
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/evm_arithmetization/src/cpu/kernel/asm/core/transfer.asm b/evm_arithmetization/src/cpu/kernel/asm/core/transfer.asm
@@ -63,6 +63,8 @@ global deduct_eth_insufficient_balance:
 // Pre stack: addr, amount, redest
 // Post stack: (empty)
 global add_eth:
+    // stack: addr, amount, retdest
+    DUP2 ISZERO %jumpi(add_eth_zero_amount)
     // stack: addr, amount, retdest
     DUP1 %insert_touched_addresses
     DUP1 %mpt_read_state_trie
@@ -84,7 +86,6 @@ global add_eth_new_account:
     // stack: null_account_ptr, addr, amount, retdest
     POP
     // stack: addr, amount, retdest
-    DUP2 ISZERO %jumpi(add_eth_new_account_zero)
     DUP1 %journal_add_account_created
     %get_trie_data_size // pointer to new account we're about to create
     // stack: new_account_ptr, addr, amount, retdest
@@ -100,7 +101,7 @@ global add_eth_new_account:
     // stack: key, new_account_ptr, retdest
     %jump(mpt_insert_state_trie)
 
-add_eth_new_account_zero:
+add_eth_zero_amount:
     // stack: addr, amount, retdest
     %pop2 JUMP