Amortize sha2 compression loop #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
muursh
approved these changes
May 16, 2024
Nashtare
commented
May 17, 2024
| %stack (shifted, rot, value) -> (rot, value, shifted) | ||
| // stack: value >> rot, value | ||
| SWAP1 | ||
| PUSH $rot |
There was a problem hiding this comment.
Yes I'm pushing again instead of calling DUP because $rot always fits in 4 bytes at most anyway, and the savings on the # CPU cycles are worth the extra overhead on BytePackingStark.
|
@muursh You may want to review the latest changes, I've pushed some additional optimizations after your review. |
Will do this evening |
Nashtare
commented
May 18, 2024
| @@ -27,6 +27,6 @@ | |||
| // stack: c, a, b, Sigma_0(a) | |||
| %sha2_majority | |||
| // stack: Maj(c, a, b), Sigma_0(a) | |||
| %add_u32 | |||
| ADD | |||
There was a problem hiding this comment.
There is no need for 32-bit reduction, as the result of this macro is being reduced after (see compression section). Similar reasoning for %sha2_temp_word1.
muursh
approved these changes
May 20, 2024
LindaGuiga
reviewed
May 20, 2024
evm_arithmetization/src/cpu/kernel/asm/hash/sha2/message_schedule.asm
Outdated
Show resolved
Hide resolved
LindaGuiga
approved these changes
May 20, 2024
Co-authored-by: Linda Guiga <[email protected]>
Co-authored-by: Linda Guiga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the tricks initially specified in the SHA1 specs for the macros
sha2_choiceandsha2_majority, as well as reducingu32addition chain overhead for already reduced inputs.Yields ~4.6% savings for SHA2 precompile.