Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-existing public dep __compat_primitive_types #321

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

BGluth
Copy link
Contributor

@BGluth BGluth commented Jun 24, 2024

Something happened in the merge zero_bin PR (#279) where a local-renamed dep (something that is not on crates.io) got set just with a semver. Somehow Cargo is still able to build fine (not sure how...), but rust-analyzer (at least on my end) fails to make it past parsing the root Cargo.toml. This PR fixes this issue.

- Something happened in the merge `zero_bin` PR (#279) where a
  local-renamed dep (something that is not on `crates.io`) got set just
  with a semver. Somehow `Cargo` is still able to build fine (not sure
  how...), but `rust-analyzer` (at least on my end) fails to make it past
  parsing the root `Cargo.toml`. This PR fixes this issue.
@BGluth BGluth requested review from muursh and Nashtare as code owners June 24, 2024 18:49
@BGluth BGluth changed the title Removed non-existing dep public __compat_primitive_types Removed non-existing public dep __compat_primitive_types Jun 24, 2024
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this compatibility layer only matters (for now) on zero-bin where it is properly imported.

@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 24, 2024
@Nashtare Nashtare merged commit ca420ed into develop Jun 24, 2024
11 checks passed
@Nashtare Nashtare deleted the fix/__compat_primitive_types_dep_fix branch June 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants