Add non jumpdests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4l0n50
added
the
soundness
dvdplm
reviewed
Feb 15, 2024
evm_arithmetization/src/cpu/kernel/asm/core/jumpdest_analysis.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/core/jumpdest_analysis.asm
Outdated
Show resolved
Hide resolved
I actually forgot to add this test and I discovered some small bugs. Thanks! |
Co-authored-by: David <[email protected]>
Nashtare
added
the
crate: evm_arithmetization
Nashtare
reviewed
Feb 20, 2024
There was a problem hiding this comment.
Not an actual review, but because this touches the jumpdest analysis logic, could you address the comment of the previous PR that got forgotten? 😅
log::debug!("jdt = {:?}", interpreter.jumpdest_table);
Move it to log::trace! and not abbreviate jdt for clarity. Thanks!
hratoanina
approved these changes
Feb 21, 2024
evm_arithmetization/src/cpu/kernel/asm/core/jumpdest_analysis.asm
Outdated
Show resolved
Hide resolved
Nashtare
reviewed
Feb 22, 2024
BGluth
added a commit
that referenced
this pull request
Jun 17, 2024
Fixed proof gen debug script not forcing `1` worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra verification to
invalid_jump_jumpi_destination_commonthat verifies that the jump destination is indeed not a jumpdest. This is done by non-deterministically guessing the closest previous opcode and verifying that after callingwrite_table_if_jumpdest, the corresponding bit in@SEGMENT_JUMPDEST_BITSis still 0.Closes #27.