Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PROVER_INPUT opcode value #42

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Nashtare
Copy link
Collaborator

PROVER_INPUT custom opcode is currently set to 0x49, which would conflict with the new BLOBHASH opcode introduced in EIP-4844 for Cancun (see #41).

The new value is set to 0xEE, to still easily distinguish it from all the PUSH variants it is combined with on the CPU side.

@Nashtare Nashtare added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Feb 16, 2024
@Nashtare Nashtare added this to the Cancun - Q1 2024 milestone Feb 16, 2024
@Nashtare Nashtare self-assigned this Feb 16, 2024
@Nashtare Nashtare merged commit de03ac3 into cancun_eip_4788 Feb 18, 2024
5 checks passed
@Nashtare Nashtare deleted the move-prover-input-opcode branch February 18, 2024 14:32
@Nashtare Nashtare restored the move-prover-input-opcode branch February 18, 2024 14:33
Nashtare added a commit that referenced this pull request Feb 18, 2024
* Implement EIP-4788

* Cleanup test suite

* Fix tests

* Apply comments

* Update PROVER_INPUT opcode value (#42)
@Nashtare Nashtare mentioned this pull request Feb 18, 2024
10 tasks
@Nashtare Nashtare deleted the move-prover-input-opcode branch February 21, 2024 23:08
BGluth pushed a commit that referenced this pull request Jun 17, 2024
Ran `cargo update` & `cargo upgrades`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants