Withdrawls not in state trie fix #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGluth
added
bug
muursh
approved these changes
Feb 16, 2024
BGluth
added a commit
that referenced
this pull request
Jun 17, 2024
Updated `.gitignore` to ignore generated plonky2 state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was actually already a PR for this, but it was to merge back into
john_temp_fix_branch. That branch had another fix applied to it later on, so I figured that it's probably better to split them into two separate PRs.This is identical to 18 except that I addressed the requested changes in the comments, so hopefully this should be a easy review.