Code hash resolve fix + cleanup #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Although we were adding any contract code created to the local code hash resolve table for the current txn, we were not adding this into the "global" lookup table. - Also cleaned up the logic for resolving code hashes.
BGluth
added
bug
Co-authored-by: Robin Salen <[email protected]>
muursh
approved these changes
Feb 16, 2024
|
Nice job |
|
@BGluth Let's maybe only do squash-merges from now, especially as we have all these repos together, to get a straightforward history? (I think this can be enforced in the repo settings by default) |
|
@Nashtare Yeah I'm fine with that. |
|
I had updated the auto-merge 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we were adding code that was created during a txn to the local code hash resolve table, it was not getting added to the "global" lookup table. Previously I was using this funny closure to resolve code hashes, but this is pretty
unusable as soon as you need to add new entries to the current table. I ended up replacing this with a struct called
CodeHashResolving, which I think is a lot easier to read.