Skip to content

Commit

Permalink
Removed a scenario where only in blue theme the beetle icon was visib…
Browse files Browse the repository at this point in the history
…le (#883)

* removed the scenario where beegleicon was only shown only for blue theme.

added id to beetleicon also

* version bump

* updated package.lock

---------

Co-authored-by: Shamsuddin Shamsuddin <[email protected]>
  • Loading branch information
yamalameyooooo and sshamsudRH authored Jun 11, 2024
1 parent 9fc17fc commit 16985d4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
6 changes: 3 additions & 3 deletions packages/opc-feedback/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/opc-feedback/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@one-platform/opc-feedback",
"version": "0.2.0-alpha",
"version": "0.2.1-alpha",
"description": "opc-feedback component follows the One Platform design system and can be used as a popup to collect feedback from the end-users.",
"scripts": {
"dev": "webpack serve",
Expand Down
3 changes: 2 additions & 1 deletion packages/opc-feedback/src/opc-feedback.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,12 @@ export class OpcFeedback extends LitElement {
this._openConfirmationModal ||
this._openInitialModal ||
this._openBugModal;
if (this.theme === 'blue' && !isModelOpen) {
if (!isModelOpen) {
return html`<img
src=${beetleIcon}
width="20px"
height="20px"
id="beetleIcon"
alt="beetle"
class="pf-u-mr-xs"
/>`;
Expand Down

0 comments on commit 16985d4

Please sign in to comment.