Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a property named showBeetleIcon t hide or show the beetle icon on the feedback button #884

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

yamalameyooooo
Copy link
Collaborator

@yamalameyooooo yamalameyooooo commented Jun 11, 2024

Closes

Added a property named showBeetleIcon to hide or show the beetle icon on the feedback button

Explain the feature/fix

Added a property named showBeetleIcon to hide or show the beetle icon on the feedback button

Does this PR introduce a breaking change

No

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • My changes generate no new warnings
  • I have performed a self-review of my own code
  • I have documented my code, particularly in areas like todo, complex logic, quick fix, temporary patch, etc.

If it is a new component

  • Does your component follow One Platform style guidelines?
  • Does your component web accessibility standards? Helper Doc
  • Does your component support desktop screen sizes (350px, 720px, 1150px ,1920px)

Browsers you have tested in

  • Latest two versions of Mozilla Firefox and Google Chrome supported by Red Hat Enterprise Linux distribution
  • Google Chrome [Latest 2 versions]
  • Mozilla Firefox [Latest 2 versions]
  • Microsoft Edge [Latest 2 versions]
  • Apple Safari [Latest 2 versions]
  • Microsoft Internet Explorer 11

@hybridx hybridx requested review from hybridx, riginoommen, gisumit and a team June 11, 2024 10:20
@hybridx hybridx merged commit d808506 into 1-Platform:master Jun 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants