Remove Rack::ContentLength from being loaded outside of Rails #10331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Bug Fix, Remove Rack::ContentLength from being loaded outside of Rails
zachmargolis
approved these changes
Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This fix is tied to the issues in #10304 / #10318.
RequestStoredepends onRack::BodyProxy, which depends on the close method being called on the body so it can run the callbacks. Mysteriously, this wasn't happening, which causedRequestStoreto not clean up after a request.After digging a bit and removing as many Rack middlewares as possible and seeing what might causes the change in behavior, the culprit seems to be
use Rack::ContentLengthbeing called outside the Rails application. In testing this change, Content-Length is returned regardless due to the web server rather than application server handling it, and there should be no impact. I testedRequestStorea bit and it seemed to behave as expected with this change.The issue was present when using both Puma and WEBrick since they both rely on being able to call
closeon the body (Puma, WEBrick). I couldn't validate Passenger locally due to phusion/passenger#2508, but I suspect the result would be similar.