Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT] Update NimBLE-Arduino to 2.2.0 #2140

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

h2zero
Copy link
Collaborator

@h2zero h2zero commented Dec 19, 2024

Description:

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@h2zero h2zero marked this pull request as draft December 19, 2024 03:21
@h2zero h2zero force-pushed the nimble-update branch 4 times, most recently from c004fe9 to 626b29e Compare December 20, 2024 14:51
@h2zero
Copy link
Collaborator Author

h2zero commented Dec 20, 2024

Ready for testing if anyone is interested.

@h2zero h2zero marked this pull request as ready for review December 20, 2024 22:06
@h2zero h2zero requested a review from 1technophile December 20, 2024 22:06
@h2zero h2zero force-pushed the nimble-update branch 2 times, most recently from 5b3b831 to 94f1920 Compare December 23, 2024 20:36
@h2zero h2zero force-pushed the nimble-update branch 2 times, most recently from 0597a3b to 27a0547 Compare January 6, 2025 23:13
@h2zero h2zero changed the title Update NimBLE-Arduino to 2.1.1 Update NimBLE-Arduino to 2.1.3 Jan 6, 2025
@h2zero h2zero force-pushed the nimble-update branch 3 times, most recently from edc870e to f73c863 Compare January 13, 2025 22:48
@h2zero h2zero changed the title Update NimBLE-Arduino to 2.1.3 Update NimBLE-Arduino to 2.2.0 Jan 13, 2025
@1technophile 1technophile changed the title Update NimBLE-Arduino to 2.2.0 [BT] Update NimBLE-Arduino to 2.2.0 Jan 14, 2025
@peshovec
Copy link
Contributor

Hi, i tried to run some test with this PR applied.
Should it be used with framework = arduino, espidf ? I ask, as in my setup i did not succeed to test with idf (i use manual wifi configuration and hit some duplicate names of defines and struct ...)

This question is raised, as my normal tests (without specifying framework) are not stable. That's why i decide to try predefined configured environments and saw env:esp32dev-ble-idf..

@h2zero
Copy link
Collaborator Author

h2zero commented Jan 21, 2025

If using the arduino, espidf framework then the esp-nimble-cpp library should be used instead of NimBLE-Arduino

@peshovec
Copy link
Contributor

10x, had to modify the define wifi_ssid (as i use manual wifi config and the idf version have wifi_ssid named structure) and was able to test it too.

So my observation (both with Nimble-Arduino and esp-nimble-cpp ) with the PR applied are not good. My esp keeps rebooting.
From the mqtt messages, it seems (in both cases), that somehow is related to the id field. :

{"id":",��?","mac_type":1,"adv_type":0,"rssi":-95,"distance":35.51099766,"servicedata":"04466072a6ae2125512f23942471cc8d628b93d5b0","servicedatauuid":"0xfcf1"}
{"id":"␦��\n�6XJ�a��?T","mac_type":1,"adv_type":0,"rssi":-93,"distance":30.15532078,"servicedata":"04accc85a0b4e4d7523ef2ffd6b84b39bae8825335","servicedatauuid":"0xfcf1"}

Happy to run more detailed test (in the weeknd if physical access to the esp will be needed)

@peshovec
Copy link
Contributor

peshovec commented Jan 24, 2025

Turns out, it was my setup (probably some compile caches), now after full clean and build it is working ok (no reboots so far).
After some time (right now it is the idf version), will be able to confirm for the nimble too. (i am pretty sure it will work, as in my setup i use arduinojson 7.3.1 and some refactoring is needed when extracting json fields)

edit: tested with Nimble-Arduino too - it is ok too, working as expected.

@h2zero
Copy link
Collaborator Author

h2zero commented Jan 24, 2025

Cool, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants